Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: corrections #1473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CMake: corrections #1473

wants to merge 3 commits into from

Conversation

scivision
Copy link

  • to set default build type, it must be done before project()
  • use simpler list(APPEND to avoid typos
  • use generator expressions rather than CMAKE_C_FLAGS
  • correct use of definitions instead of options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant