Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: corrections #1473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CMake: corrections #1473

wants to merge 3 commits into from

Commits on Nov 10, 2023

  1. cmake: must set build type before project() 

    also account for env var CMAKE_BUILD_TYPE
    @scivision
    scivision committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    7d4deb8 View commit details
    Browse the repository at this point in the history

  2. cmake: use list(APPEND to avoid typos

    @scivision
    scivision committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ad83198 View commit details
    Browse the repository at this point in the history

  3. cmake: use options/defns rather than direct vars

    @scivision
    scivision committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    cf15f46 View commit details
    Browse the repository at this point in the history