Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NWB schemas v2.8.0 #630

Merged
merged 16 commits into from
Dec 3, 2024
Merged

Add support for NWB schemas v2.8.0 #630

merged 16 commits into from
Dec 3, 2024

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Nov 20, 2024

Fix #628

Motivation

Add support for NWB schema v2.8.0

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Todo

  • Add more detailed example for device in ecephys and ophys tutorials

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@rly
Copy link
Contributor

rly commented Nov 25, 2024

Thanks @ehennestad . We just released NWB schema 2.8.0.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (e070e20) to head (205083a).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   95.16%   95.17%   +0.01%     
==========================================
  Files         113      113              
  Lines        4734     4750      +16     
==========================================
+ Hits         4505     4521      +16     
  Misses        229      229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad marked this pull request as ready for review November 27, 2024 23:06
@bendichter bendichter merged commit 42e9995 into master Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Prepare for release of NWB schema 2.8.0
3 participants