Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud27: 27.1.1 -> 27.1.2 #259348

Closed
wants to merge 1 commit into from
Closed

Conversation

f2k1de
Copy link
Contributor

@f2k1de f2k1de commented Oct 6, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@cafkafk
Copy link
Member

cafkafk commented Oct 6, 2023

Result of nixpkgs-review pr 259348 run on x86_64-linux 1

1 package built:
  • nextcloud27

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 6, 2023
@bachp
Copy link
Member

bachp commented Oct 6, 2023

Sucessfully deployed and it's working. But I get the following warning in the admin overview page:

Your web server is not properly set up to resolve "/ocm-provider/". This is most likely related to a web server configuration that was not updated to deliver this folder directly. Please compare your configuration against the shipped rewrite rules in ".htaccess" for Apache or the provided one in the documentation for Nginx at it's documentation page ↗. On Nginx those are typically the lines starting with "location ~" that need an update.

Maybe a change to the nginx config is necessary in the module

@SuperSandro2000
Copy link
Member

could be this commit nextcloud/server@6200c91

@bachp
Copy link
Member

bachp commented Oct 7, 2023

Looks like others are having the same issue nextcloud/server#40803

@SuperSandro2000
Copy link
Member

I think this doc change is relevant for us https://github.com/nextcloud/documentation/pull/11179/files

In fact removing the redirect fixed the admin message for me

@SuperSandro2000
Copy link
Member

Please pick to fix the warning SuperSandro2000@a5624e4

@Ma27
Copy link
Member

Ma27 commented Oct 7, 2023

fwiw this patch can't be applied as-is since it'd break nextcloud26 (also 25, but that's almost EOL, so it doesn't count). I started fixing that, but it may take me a day until I can submit the patches :)

@wegank
Copy link
Member

wegank commented Oct 12, 2023

Superseded by #259967.

@wegank wegank closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants