nextcloud: 27.1.0 -> 27.1.2, update nginx, drop nextcloud25 #259967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EOL of Nextcloud v25 is scheduled by the end of this month.
Ma27
requested review from
RaitoBezarius,
bachp,
dotlambda,
SuperSandro2000 and
cafkafk
github-actions
bot
added
6.topic: nixos
|
There is some reference left which we need to adjust/delete to fix the manual build. |
12 tasks
First of all, a few cleanups were made to make it more readable:
* Reordered the sections by their priority so what you're reading in Nix
is also what you get in the final nginx.conf.
* Unified media/asset locations
Most notably, this fixes the
Your web server is not properly set up to resolve "/ocm-provider/".
warning since 27.1.2 where `ocm-provider` was moved from a static
directory in the source tarball to a dynamic HTTP route[1].
Additionally, the following things were fixed:
* The 404 checks for build/tests/etc. are now guaranteed to be before
the `.php` location match and it's not implicitly relied upon Nix's
internal attribute sorting anymore.
* `.wasm` files are supported properly and a correct `Content-Type` is
set.
* For "legacy" routes (e.g. `ocs-provider`/`cron`/etc) a `rewrite` rule
inside the location for fastcgi is used as recommended by upstream[2].
This also makes it easier to understand the purpose of the location
itself (i.e. use fastcgi for PHP code).
[1] nextcloud/documentation#11179
[2] https://docs.nextcloud.com/server/27/admin_manual/installation/nginx.html
Ma27
force-pushed
the
nextcloud-cleanups
branch
from
fae8606 to
ad57ad1
Compare
github-actions
bot
added
8.has: documentation
|
Result of 1 package blacklisted:
1 package built:
|
ofborg
bot
added
11.by: package-maintainer
SuperSandro2000
approved these changes
Oct 9, 2023
delroth
added
the
12.approvals: 1
cafkafk
approved these changes
Oct 9, 2023
delroth
added
12.approvals: 2
delroth
added
12.approvals: 3+
onny
approved these changes
Oct 10, 2023
|
@onny any specific reason you have assigned this PR to you? Anyways, I think we have quite a good test coverage of this change now, so I'm inclined to merge soonish. |
|
Will review today
Le mar. 10 oct. 2023 à 14:07, Maximilian Bosch ***@***.***> a
écrit :
… @onny <https://github.com/onny> any specific reason you have assigned
this PR to you?
@RaitoBezarius <https://github.com/RaitoBezarius> any chance you have the
capacity to review this?
Anyways, I think we have quite a good test coverage of this change now, so
I'm inclined to merge soonish.
—
Reply to this email directly, view it on GitHub
<#259967 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMZRBX4KQGD3X2GKPY73TX6U3AJAVCNFSM6AAAAAA5YSLVCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJVGI2DINJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
12 tasks
SuperSandro2000
approved these changes
Oct 13, 2023
RaitoBezarius
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update was originally done by @f2k1de in #259348 (I applied their patch via
git am -3, so author information is kept - I hope the way I did that is OK for you!)Also added the following changes / fixes:
ocm-providerisn't a directory anymore) and tried to clean it up a bit (see commit message for more details)enableBrokenCiphersForSSEhack & openssl 1.1 support (not needed anymore, nc26 and later have a PHP-baked RC4 implementation for legacy SSE setups)Deployed this to my own instance and tested via the web UI, Nextcloud client for file syncing & Cal/CardDAV without issues.
Closes #259348
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)