Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llm-ls: fix darwin build (in progress) #274012

Closed
wants to merge 1 commit into from

Conversation

JackSullivan
Copy link
Contributor

See #273596, related to #19098.

Currently, this change builds successfully for 933d7dc (my nixpkgs/nixos-23.11) and 06b4b4e (my nixpkgs unstable), but it does not build when branched from 102c342. I'd love some help debugging the reason. The log from the build failure is here. @jfvillablanca is the maintainer listed for this package and asked me to shepherd this because they do not have access to an aarch64-darwin machine.

Description of changes

Added in a flag to not use Link-Time Optimization as per #19098. (The particular change is shameless lifted from 3ade63b, thanks @michaelhthomas)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jfvillablanca
Copy link
Member

Thanks for the PR!
I'd defer to a nixpkgs-committer or someone with domain knowledge on the approval of this one 😅

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants