ldc: 1.36.0 -> 1.38.0, clean up #293417
ldc: 1.36.0 -> 1.38.0, clean up #293417
Conversation
|
Just a heads up: the other PRs have been merged |
|
Thanks. 1.38.0 is almost ready, I'll wait for that first.
|
|
Updated to 1.38.0 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3920 |
jtbx
force-pushed
the
ldc-1.37.0
branch
2 times, most recently
from
e13132d
to
b00a845
Compare
|
Result of 4 packages failed to build:
14 packages built:
|
Interesting... I wonder what the breaking change was. |
|
Tilix fails to build because gtkd fails to build, and gtkd fails to build because Inochi fails because the json library attempts to throw an immutable exception: I can't find anything in the changelogs for 2.107-2.108 about this either... |
|
If you look at the inochi logs, the errors are earlier. These errors are results of this being fixed: https://issues.dlang.org/show_bug.cgi?id=24387 in I also sent this info to the inochi devs. |
|
Ah I didn't see that error, that makes a lot more sense now. |
|
Okay, so I came up with a fix for This should go in the Where diff --git a/source/inochi2d/core/nodes/drivers/package.d b/source/inochi2d/core/nodes/drivers/package.d
index 9a46846..01046b6 100644
--- a/source/inochi2d/core/nodes/drivers/package.d
+++ b/source/inochi2d/core/nodes/drivers/package.d
@@ -17,10 +17,8 @@ public import inochi2d.core.nodes.drivers.simplephysics;
*/
@TypeId("Driver")
abstract class Driver : Node {
-private:
- this() { }
-
protected:
+ this() { }
/**
Constructs a new Driver node
*/
diff --git a/source/inochi2d/core/nodes/package.d b/source/inochi2d/core/nodes/package.d
index 6090355..5045361 100644
--- a/source/inochi2d/core/nodes/package.d
+++ b/source/inochi2d/core/nodes/package.d
@@ -74,8 +74,6 @@ void inClearUUIDs() {
@TypeId("Node")
class Node : ISerializable {
private:
- this() { }
-
@Ignore
Puppet puppet_;
@@ -98,6 +96,8 @@ private:
string nodePath_;
protected:
+ this() { }
+
bool preProcessed = false;
bool postProcessed = false;
Not sure if this should be in this PR or a separate one. |
|
Good point, the dmd package does the same. I can change it back. |
|
@lionello was there any reason for the package versions to be in separate files? |
jtbx
force-pushed
the
ldc-1.37.0
branch
2 times, most recently
from
e27b631
to
9d75b55
Compare
|
Now that #314953 is merged, the inochi patches can probably be dropped |
|
Yep, everything builds now: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4038 |
|
Result of 1 package marked as broken and skipped:
15 packages built:
|
I read something about aarch64 support being dropped for inochi, but thought it would be only for next major release. Edit: nevermind, I just misinterpreted the output of |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4050 |
|
Result of 18 packages built:
|
Asahi Lina would never let that happen ;) |
|
Thank you! |
Description of changes
https://github.com/ldc-developers/ldc/releases/tag/v1.37.0
(edit 2024/05/12) https://github.com/ldc-developers/ldc/releases/tag/v1.38.0
Also migrate to pkgs/by-name and clean up the package a bit (see commits).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.