Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inochi-creator: 0.8.4 -> 0.8.5; inochi-session: 0.8.3 -> 0.8.4 #314953

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented May 26, 2024

Description of changes

Releases:
https://github.com/Inochi2D/inochi-creator/releases
https://github.com/Inochi2D/inochi-session/releases

One notable fix in these releases is fixing support for newer Dlang versions.
Related PR, where this was manually patched in: #293417

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jtbx
Copy link
Member

jtbx commented Jun 4, 2024

Hi, are you saying the bug discussed in #293417 was fixed in this release? I can't find anything about it in the changelogs. If so I can drop 581ee5094cc1c41f4784c44985be280ba3fdec8f and mark it as draft until this gets merged.

@pbsds
Copy link
Member

pbsds commented Jun 5, 2024

Result of nixpkgs-review pr 314953 run on x86_64-linux 1

2 packages built:
  • inochi-creator
  • inochi-session

@pbsds
Copy link
Member

pbsds commented Jun 5, 2024

Hi, are you saying the bug discussed in #293417 was fixed in this release? I can't find anything about it in the changelogs. If so I can drop 581ee50 and mark it as draft until this gets merged.

I'll merge this now, so try and drop that patch and see if it still builds in nixpkgs-review

@pbsds pbsds merged commit 65949ff into NixOS:master Jun 5, 2024
29 checks passed
@TomaSajt TomaSajt mentioned this pull request Jun 5, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants