Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ayatana-indicator-sound: init & add to Lomiri #305127

Merged

Conversation

OPNA2608
Copy link
Contributor

Description of changes

An indicator for sound device control.

https://github.com/AyatanaIndicators/ayatana-indicator-sound

image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank
Copy link
Member

wegank commented Apr 19, 2024

@ofborg build ayatana-indicator-sound ayatana-indicator-sound.passthru.tests

@OPNA2608

This comment was marked as outdated.

@OPNA2608
Copy link
Contributor Author

Okay, lomiri VM test is seemingly consistently failing on aarch64 ofborg when it tries to use OCR on indicator-client. That app behaves pretty inconsistently with only a keyboard so it kind of sucks for this kind of testing, but it used to work well enough in previous runs. Might be better to put some time into that ydotool module PR, so I can rewrite the indicator part of the test to not have to rely on indicator-client…

@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-sound branch 2 times, most recently from 9c3471a to c099110 Compare May 19, 2024 20:57
@OPNA2608
Copy link
Contributor Author

@ofborg build ayatana-indicator-sound ayatana-indicator-sound.passthru.tests

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 20, 2024

@ofborg build nixosTests.lomiri

@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-sound branch from c099110 to e2e3f87 Compare May 21, 2024 03:01
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@@ -38,6 +38,7 @@ in {
]);
};

hardware.pulseaudio.enable = lib.mkDefault true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are sure we want to use legacy pulseaudio by default and pipewire?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UBports is using PA still, as does Debian with their Lomiri packaging. I haven't had any issues with it so far, so I see no urgency to push for PW right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipewire has lots of nice features for example you can easily switch the BT codec without digging deep into the menues.

nixos/modules/services/desktop-managers/lomiri.nix Outdated Show resolved Hide resolved
libnotify
libpulseaudio
libxml2
systemd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could slim this down to libsystemd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A libsystemd doesn't seem to exist.

@OPNA2608 OPNA2608 force-pushed the init/lomiri/ayatana-indicator-sound branch from e2e3f87 to af54596 Compare May 21, 2024 14:15
@OPNA2608
Copy link
Contributor Author

Rebased.

@SuperSandro2000 SuperSandro2000 merged commit 6a82eb3 into NixOS:master May 23, 2024
29 checks passed
@OPNA2608 OPNA2608 added the backport release-24.05 Backport PR automatically label May 23, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants