-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ayatana-indicator-sound: init & add to Lomiri #305127
ayatana-indicator-sound: init & add to Lomiri #305127
Conversation
@ofborg build ayatana-indicator-sound ayatana-indicator-sound.passthru.tests |
This comment was marked as outdated.
This comment was marked as outdated.
Okay, lomiri VM test is seemingly consistently failing on aarch64 ofborg when it tries to use OCR on indicator-client. That app behaves pretty inconsistently with only a keyboard so it kind of sucks for this kind of testing, but it used to work well enough in previous runs. Might be better to put some time into that ydotool module PR, so I can rewrite the indicator part of the test to not have to rely on indicator-client… |
9c3471a
to
c099110
Compare
@ofborg build ayatana-indicator-sound ayatana-indicator-sound.passthru.tests |
@ofborg build nixosTests.lomiri |
c099110
to
e2e3f87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
@@ -38,6 +38,7 @@ in { | |||
]); | |||
}; | |||
|
|||
hardware.pulseaudio.enable = lib.mkDefault true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are sure we want to use legacy pulseaudio by default and pipewire?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UBports is using PA still, as does Debian with their Lomiri packaging. I haven't had any issues with it so far, so I see no urgency to push for PW right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipewire has lots of nice features for example you can easily switch the BT codec without digging deep into the menues.
libnotify | ||
libpulseaudio | ||
libxml2 | ||
systemd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could slim this down to libsystemd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A libsystemd
doesn't seem to exist.
e2e3f87
to
af54596
Compare
Rebased. |
Successfully created backport PR for |
Description of changes
An indicator for sound device control.
https://github.com/AyatanaIndicators/ayatana-indicator-sound
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.