[refactor] RT-DETR hybrid encoder #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illian01
added
the
refactoring
illian01
reviewed
Nov 12, 2024
Comment on lines
174
to
177
| class RepConv(nn.Module): | ||
| """ | ||
| A convolutional block that combines two convolution layers (kernel and point-wise conv). | ||
| """ |
There was a problem hiding this comment.
I think renaming RepVggBlock -> RepConv is not proper to this class.
Actually, RepVGG block is came from https://arxiv.org/abs/2101.03697, this block is named by author.
Also, RepVggBlock should have residual connection option according to the original paper.
And, please add original codebase reference so that we can keep an eye on code license issue.
There was a problem hiding this comment.
Thank you for the suggestions! I've include your feedback via additional commits👍
…nto 529-refactor-repblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to refactor replaceable blocks within RT-DETR hybrid encoder (e.g., ConvNormLayer, RepVGG).
Closes: #529
We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.
Change(s)
CSPRepLayerto op.customConvNormLayertoConvLayerin op.customRepVGGwith custom operation layers.Code Formatting
If you PR to either
masterordevbranch, you should follow the code linting process. Please check your code withlint_check.shin./scriptsdirectory.For more information, please read the contribution guide in
CONTRIBUTING.md.Changelog
If your PR is granted to
devbranch, codeowner will add a brief summary of the change to the Upcoming Release section of theCHANGELOG.mdfile including a link to the PR (formatted in markdown) and a link to your github profile.For example,
Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the
CHANGELOG.md.