Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ieee1609.2.1 #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Ieee1609.2.1 #8

wants to merge 5 commits into from

Conversation

wooks-ssoltech
Copy link

reopen pull request for adding TCI message for IEEE1609.2.1 testing.

wooks-ssoltech and others added 2 commits January 9, 2024 18:00
add TCI160921.asn to the script Create_TCall.bat
add Indication for IEEE1609.2.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To allow for further future extension of the Event enumeration without breaking encoding compatibility, we should avoid using as many explicit values for the dot2dot1 events. I suggest changing the Event entry to a single ‘eDot2Dot1’ value. We can then extend the EventParams choice to include a new entry for dot2dot1Params. As an example:

EventParams ::= CHOICE{
service [0] ServiceParameters,
wsm [1] WsmParameters,
ip [2] IpParameters,
radioframe [3] RadioParameters,
security [4] SecResultParams,
...
dot2dot1 [5] Dot2Dot1Params
}

Dot2Dot1Params ::= SEQUENCE {
state Dot2Dot1State,

}

Dot2Dot1State ::= ENUMERATED {
eInitialised (1),
eEnrolled (2),
eAuthReqResp (3),
eAuthDownResp (4),
eProvisioned (5),
exception (15) --exception added with large value to allow for future expansion
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I an going to revise the code and request merge. Thanks

only one eDot2Dot1 event used instead of adding all dot2dot1 state change event as events.
extend the EventParams choice to include a new entry for dot2dot1Params.
Copy link
Collaborator

@neil-keysight-com neil-keysight-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes appear backwards compatible per compilation and manual examination. Should be good to merge to main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants