-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ieee1609.2.1 #8
base: main
Are you sure you want to change the base?
Ieee1609.2.1 #8
Conversation
add TCI160921.asn to the script Create_TCall.bat add Indication for IEEE1609.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To allow for further future extension of the Event enumeration without breaking encoding compatibility, we should avoid using as many explicit values for the dot2dot1 events. I suggest changing the Event entry to a single ‘eDot2Dot1’ value. We can then extend the EventParams choice to include a new entry for dot2dot1Params. As an example:
EventParams ::= CHOICE{
service [0] ServiceParameters,
wsm [1] WsmParameters,
ip [2] IpParameters,
radioframe [3] RadioParameters,
security [4] SecResultParams,
...
dot2dot1 [5] Dot2Dot1Params
}
Dot2Dot1Params ::= SEQUENCE {
state Dot2Dot1State,
…
}
Dot2Dot1State ::= ENUMERATED {
eInitialised (1),
eEnrolled (2),
eAuthReqResp (3),
eAuthDownResp (4),
eProvisioned (5),
exception (15) --exception added with large value to allow for future expansion
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I an going to revise the code and request merge. Thanks
only one eDot2Dot1 event used instead of adding all dot2dot1 state change event as events. extend the EventParams choice to include a new entry for dot2dot1Params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes appear backwards compatible per compilation and manual examination. Should be good to merge to main branch.
reopen pull request for adding TCI message for IEEE1609.2.1 testing.