-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ieee1609.2.1 #8
Open
wooks-ssoltech
wants to merge
5
commits into
OATCI:main
Choose a base branch
from
ssoltech:IEEE1609.2.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ieee1609.2.1 #8
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
142152c
IMPORT CompactTimeConfidence missing
wooks-ssoltech 8c7c18e
add TCI160921.asn
wooks-ssoltech fca0417
TCI160921 Frame added
wooks-ssoltech d3fb717
revised as Neil's review.
wooks-ssoltech 4f5e317
Dot2Dot1Indication event, eventParams changed
wooks-ssoltech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| TCI-160921 | ||
| DEFINITIONS AUTOMATIC TAGS ::= | ||
| BEGIN | ||
|
|
||
| IMPORTS | ||
| Exception, | ||
| Response, | ||
| MsgID FROM TCI-CommonTypes | ||
|
|
||
| ResponseInfo FROM TCI-responseInfo | ||
|
|
||
| Indication FROM TCI-indication | ||
|
|
||
| ; | ||
|
|
||
|
|
||
| TCI160921 ::= CHOICE{ | ||
| request [0] Request160921, -- Add new request message types | ||
| response [1] Response, | ||
| indication [2] Dot2Dot1Indication, | ||
| responseInfo [3] Dot2Dot1ResponseInfo, | ||
| exception [4] Exception, | ||
| ... | ||
| } | ||
|
|
||
| SetInitialize ::= SEQUENCE { | ||
| bootstrapUrl VisibleString, | ||
| ... | ||
| } | ||
|
|
||
| StartProvisioning ::= BOOLEAN | ||
|
|
||
| UnAuthorized ::= BOOLEAN | ||
| UnEnrolled ::= BOOLEAN | ||
| UnInitialized ::= BOOLEAN | ||
| Authorized ::= BOOLEAN | ||
|
|
||
| SetPKIState ::= CHOICE { | ||
| unInitialized [0] UnInitialized, | ||
| unEnrolled [1] UnEnrolled, | ||
| unAuthorized [2] UnAuthorized, | ||
| authorized [3] Authorized, | ||
| ... | ||
| } | ||
|
|
||
| Request160921 ::= SEQUENCE { | ||
| messageId MESSAGE-ID-AND-TYPE160921.&id({MessageTypes}), | ||
| value MESSAGE-ID-AND-TYPE160921.&Type({MessageTypes}{@.messageId}), | ||
| ... | ||
| } | ||
|
|
||
| MESSAGE-ID-AND-TYPE160921 ::= CLASS { | ||
| &id MsgID UNIQUE, | ||
| &Type | ||
| } WITH SYNTAX {&Type IDENTIFIED BY &id} | ||
|
|
||
| MessageTypes MESSAGE-ID-AND-TYPE160921 ::= { | ||
| { SetInitialize IDENTIFIED BY setInitialize } | | ||
| { SetPKIState IDENTIFIED BY setPKIState} | | ||
| { StartProvisioning IDENTIFIED BY startProvisioning } | ||
| } | ||
|
|
||
| setInitialize MsgID ::= 1 | ||
| setPKIState MsgID ::= 2 | ||
| startProvisioning MsgID ::= 3 | ||
|
|
||
|
|
||
|
|
||
| Dot2Dot1Indication ::= Indication (WITH COMPONENTS { | ||
| radio, | ||
| event ( | ||
| eDot2Dot1Initialized | | ||
| eDot2Dot1Enrolled | | ||
| eDot2Dot1AuthReqResp | | ||
| eDot2Dot1AuthDownResp | | ||
| eDot2Dot1Provisioned | | ||
| exception | ||
| ), | ||
| eventParams ( | ||
| WITH COMPONENTS {service} | -- Add appropriate event params for Dot2Dot1 | ||
| WITH COMPONENTS {wsm} | | ||
| WITH COMPONENTS {ip} | | ||
| WITH COMPONENTS {security} | ||
| ) OPTIONAL, | ||
| pdu OPTIONAL, | ||
| exception OPTIONAL | ||
| }) | ||
|
|
||
| Dot2Dot1ResponseInfo ::= ResponseInfo (WITH COMPONENTS { | ||
| msgID, | ||
| resultCode, | ||
| info (WITH COMPONENTS {ipv6InterfaceInfo}) OPTIONAL, -- Update InfoContent with security related parameters? | ||
| exception OPTIONAL | ||
| }) | ||
|
|
||
| END |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To allow for further future extension of the Event enumeration without breaking encoding compatibility, we should avoid using as many explicit values for the dot2dot1 events. I suggest changing the Event entry to a single ‘eDot2Dot1’ value. We can then extend the EventParams choice to include a new entry for dot2dot1Params. As an example:
EventParams ::= CHOICE{
service [0] ServiceParameters,
wsm [1] WsmParameters,
ip [2] IpParameters,
radioframe [3] RadioParameters,
security [4] SecResultParams,
...
dot2dot1 [5] Dot2Dot1Params
}
Dot2Dot1Params ::= SEQUENCE {
state Dot2Dot1State,
…
}
Dot2Dot1State ::= ENUMERATED {
eInitialised (1),
eEnrolled (2),
eAuthReqResp (3),
eAuthDownResp (4),
eProvisioned (5),
exception (15) --exception added with large value to allow for future expansion
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I an going to revise the code and request merge. Thanks