Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account_receipt_base #1427

Closed
wants to merge 4 commits into from

Conversation

SirTakobi
Copy link
Contributor

No description provided.

@rafaelbn
Copy link
Member

Please @SirTakobi could you explain a little bit the purpose of this module, really interested 😄 cc @Shide

@rafaelbn rafaelbn added this to the 14.0 milestone Mar 30, 2023
@SirTakobi
Copy link
Contributor Author

Please @SirTakobi could you explain a little bit the purpose of this module, really interested 😄 cc @Shide

Thanks for having a look!
The purpose of this module is to be the base for other modules that improve Receipts Management in 14.0, for instance:

Here we are also planning to add minor improvements that might not deserve a dedicated module, like:

  • the Receipts button in the partner (similar to Invoices button),
  • showing Receipts in the Invoices Report

@rafaelbn
Copy link
Member

OK! Great and thank you very much @SirTakobi for explanation.

  • We need that receipt can be created in a Account Journal Type | Miscellaneous

Do you think this is something we can improve in account_receipt_journal or you would prefer we create a new module?

The need is that in receipts, in the receipt lines, we need use more accounts type than the ones are now allowed by Odoo in Journes type "Sale"

cc @Shide

@SirTakobi SirTakobi force-pushed the 14.0-add-account_receipt_base branch from cc79d0a to 5c738dc Compare March 31, 2023 09:02
@SirTakobi
Copy link
Contributor Author

OK! Great and thank you very much @SirTakobi for explanation.

  • We need that receipt can be created in a Account Journal Type | Miscellaneous

Do you think this is something we can improve in account_receipt_journal or you would prefer we create a new module?

The need is that in receipts, in the receipt lines, we need use more accounts type than the ones are now allowed by Odoo in Journes type "Sale"

cc @Shide

@eLBati what do you think about this?

@eLBati
Copy link
Member

eLBati commented Mar 31, 2023

Ciao @rafaelbn
having account_receipt_journal a specific name, I think the modification of domain in receipt lines could go in another place, like another module or even an option in account_receipt_base

@rafaelbn
Copy link
Member

Hello Lorenzo!

Ciao @rafaelbn
having account_receipt_journal a specific name, I think the modification of domain in receipt lines could go in another place, like another module or even an option in account_receipt_base

OK, I will think about this one

another need @eLBati @SirTakobi that we can add to this module is that we can define

  • If receipts by default have empty tax or
  • Receipt journal by default set an specific tax to all lines of all receipts

This is because receipts are not invoices therefore fiscally shouldn't be reported to administrations in the same way and Mainly could don't apply any tax

Thank you!

@eLBati
Copy link
Member

eLBati commented Aug 25, 2023

Hello @rafaelbn
I think these needs could be covered later and we could merge this module as is.
What do you think?

@tafaRU
Copy link
Member

tafaRU commented Sep 4, 2023

@rafaelbn please see #1427 (comment)

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@primes2h
Copy link
Contributor

primes2h commented Sep 8, 2023

@SirTakobi @eLBati

image

Could you please force a rebuild?

@eLBati
Copy link
Member

eLBati commented Sep 9, 2023

cc @SirAionTech

@SirAionTech
Copy link

@SirTakobi @eLBati

image

Could you please force a rebuild?

cc @SirAionTech

@SirTakobi is no more used, so I superseded with #1551; this can be closed.

@tafaRU
Copy link
Member

tafaRU commented Sep 11, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@OCA-git-bot OCA-git-bot force-pushed the 14.0-add-account_receipt_base branch from 5c738dc to 1ac8c8b Compare September 11, 2023 09:40
@tafaRU tafaRU closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants