-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] account_receipt_base #1551
[ADD] account_receipt_base #1551
Conversation
(from #1427 (comment)) @primes2h here you have the runboat. @rafaelbn would you mind reviewing this? Here I have only rebased the changes of #1427.
(from #1427 (comment)) @eLBati would you mind reviewing this? Then maybe we'll be closer to merge. Thanks all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In production
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in production
Ciao @SirAionTech, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
This PR has the |
@LorenzoC0 |
I already merged his changes with SirAionTech#1. @LorenzoC0 could you please add your review here? The more approvals, the closer we are to merge 🎉 |
/ocabot rebase |
Sorry @eLBati you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
4d8a800
to
8c5734d
Compare
Fatto |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at d1b656a. Thanks a lot for contributing to OCA. ❤️ |
Supersede #1427.