Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account_receipt_base #1551

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

SirAionTech
Copy link

Supersede #1427.

@SirAionTech
Copy link
Author

SirAionTech commented Sep 11, 2023

@SirTakobi @eLBati

image

Could you please force a rebuild?

(from #1427 (comment))

@primes2h here you have the runboat.


@rafaelbn would you mind reviewing this? Here I have only rebased the changes of #1427.
And maybe you can approve the workflows.


cc @SirAionTech

(from #1427 (comment))

@eLBati would you mind reviewing this? Then maybe we'll be closer to merge.


Thanks all!

@rafaelbn rafaelbn added this to the 14.0 milestone Sep 20, 2023
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In production

Copy link

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in production

@LorenzoC0
Copy link
Contributor

Ciao @SirAionTech,
non riesco a creare una Pull Request per il tuo branch, però volevo proporti le modifiche all'interno di questo branch per poter visualizzare il widget di riconciliazione anche nelle ricevute.

Copy link
Contributor

@primes2h primes2h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@primes2h
Copy link
Contributor

@LorenzoC0
It would be better to merge this first.
You can then create a new PR with proposed changes.

@SirAionTech
Copy link
Author

@LorenzoC0 It would be better to merge this first. You can then create a new PR with proposed changes.

I already merged his changes with SirAionTech#1.

@LorenzoC0 could you please add your review here? The more approvals, the closer we are to merge 🎉

@eLBati
Copy link
Member

eLBati commented Mar 1, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @eLBati you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@SirAionTech SirAionTech force-pushed the 14.0-add-account_receipt_base branch from 4d8a800 to 8c5734d Compare March 1, 2024 08:27
@SirAionTech
Copy link
Author

/ocabot rebase

Fatto

@sergiocorato
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1551-by-sergiocorato-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 501b621 into OCA:14.0 Mar 5, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1b656a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants