[13.0][IMP] account_invoice_refund_link: Make more reliable the linking #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooking on a high level method like `_reverse_move_vals` (although still being private), makes that other modules hooking into it may alter the number of returned lines (like for example, account_invoice_refund_line_selection). We choose the low-level `copy_data` method that is used in such method for linking the refund lines with their origin ones, avoiding the problem.
|
@javierjcf this should solve your problem in #1417. Please try. |
stefan-tecnativa
approved these changes
Aug 7, 2023
CarlosRoca13
approved these changes
Aug 7, 2023
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c444ee7. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
13.0-imp-account_invoice_refund_link-solid_linking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooking on a high level method like
_reverse_move_vals(although still being private), makes that other modules hooking into it may alter the number of returned lines (like for example,account_invoice_refund_line_selection).We choose the low-level
copy_datamethod that is used in such method for linking the refund lines with their origin ones, avoiding the problem.@Tecnativa