-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 mig l10n_it_fatturapa_out_rc #3202
Conversation
/ocabot migration l10n_it_fatturapa_out_rc |
1 similar comment
/ocabot migration l10n_it_fatturapa_out_rc |
@jado95 grazie per la PR! |
2f5541d
to
fbf7073
Compare
Grazie @jado95 Puoi verificare e sistemare pre-commit e tests? |
a84f911
to
d049c7c
Compare
Segnalo #3298 |
l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py
Outdated
Show resolved
Hide resolved
46126d5
to
93feb6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
merging |
93feb6c
to
d4bc0a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
questo commento è per una issue futura non impatta sulla migrazione.
nel caso di tipo partner autofattura "Altro" e Con autofattura passiva aggiuntiva "si" quando metto in bozza una fattura passiva precedentemente confermata c'è un messaggio utente "You cannot delete a tax line as it would impact the tax report"
per proseguire è necessario cancellare le fatture collegate per poi ricrearle.
se pre me migliorie future se cancello la fattura passiva legata al RC non cancella le eventuali fatture in bozza collegate.
Currently translated at 100.0% (16 of 16 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fatturapa_out_rc Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_out_rc/it/
…orti in EUR per fatture in valuta estera
…bly no fiscalcode)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fatturapa_out_rc Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_out_rc/
…doo/odoo@ab1d7ca Otherwise tests fail raising the following errors: 2022-10-21 07:38:51,491 253 ERROR odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ERROR: TestFatturaPAXMLValidation.test_extra_EU Traceback (most recent call last): File "/opt/odoo/odoo/tools/cache.py", line 85, in lookup r = d[key] File "/opt/odoo/odoo/tools/func.py", line 71, in wrapper return func(self, *args, **kwargs) File "/opt/odoo/odoo/tools/lru.py", line 34, in __getitem__ a = self.d[obj] KeyError: ('ir.model.data', <function IrModelData.xmlid_lookup at 0x7f81573e0158>, 'product.product_product_4d') During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 213, in test_extra_EU taxes=self.tax_22ae, File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 71, in _create_invoice line_form.product_id = cls.env.ref("product.product_product_4d") File "/opt/odoo/odoo/api.py", line 514, in ref return self['ir.model.data'].xmlid_to_object(xml_id, raise_if_not_found=raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1954, in xmlid_to_object t = self.xmlid_to_res_model_res_id(xmlid, raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1938, in xmlid_to_res_model_res_id return self.xmlid_lookup(xmlid)[1:3] File "<decorator-gen-35>", line 2, in xmlid_lookup File "/opt/odoo/odoo/tools/cache.py", line 90, in lookup value = d[key] = self.method(*args, **kwargs) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1931, in xmlid_lookup raise ValueError('External ID not found in the system: %s' % xmlid) ValueError: External ID not found in the system: product.product_product_4d 2022-10-21 07:38:51,495 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: Starting TestFatturaPAXMLValidation.test_intra_EU ... 2022-10-21 07:38:53,109 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ====================================================================== 2022-10-21 07:38:53,109 253 ERROR odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ERROR: TestFatturaPAXMLValidation.test_intra_EU Traceback (most recent call last): File "/opt/odoo/odoo/tools/cache.py", line 85, in lookup r = d[key] File "/opt/odoo/odoo/tools/func.py", line 71, in wrapper return func(self, *args, **kwargs) File "/opt/odoo/odoo/tools/lru.py", line 34, in __getitem__ a = self.d[obj] KeyError: ('ir.model.data', <function IrModelData.xmlid_lookup at 0x7f81573e0158>, 'product.product_product_4d') During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 91, in test_intra_EU taxes=self.tax_22ai, File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 71, in _create_invoice line_form.product_id = cls.env.ref("product.product_product_4d") File "/opt/odoo/odoo/api.py", line 514, in ref return self['ir.model.data'].xmlid_to_object(xml_id, raise_if_not_found=raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1954, in xmlid_to_object t = self.xmlid_to_res_model_res_id(xmlid, raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1938, in xmlid_to_res_model_res_id return self.xmlid_lookup(xmlid)[1:3] File "<decorator-gen-35>", line 2, in xmlid_lookup File "/opt/odoo/odoo/tools/cache.py", line 90, in lookup value = d[key] = self.method(*args, **kwargs) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1931, in xmlid_lookup raise ValueError('External ID not found in the system: %s' % xmlid) ValueError: External ID not found in the system: product.product_product_4d 2022-10-21 07:38:53,111 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: Starting TestFatturaPAXMLValidation.test_intra_EU_customer ... 2022-10-21 07:38:54,674 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ====================================================================== 2022-10-21 07:38:54,674 253 ERROR odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ERROR: TestFatturaPAXMLValidation.test_intra_EU_customer Traceback (most recent call last): File "/opt/odoo/odoo/tools/cache.py", line 85, in lookup r = d[key] File "/opt/odoo/odoo/tools/func.py", line 71, in wrapper return func(self, *args, **kwargs) File "/opt/odoo/odoo/tools/lru.py", line 34, in __getitem__ a = self.d[obj] KeyError: ('ir.model.data', <function IrModelData.xmlid_lookup at 0x7f81573e0158>, 'product.product_product_4d') During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 132, in test_intra_EU_customer taxes=self.tax_22vi, File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 71, in _create_invoice line_form.product_id = cls.env.ref("product.product_product_4d") File "/opt/odoo/odoo/api.py", line 514, in ref return self['ir.model.data'].xmlid_to_object(xml_id, raise_if_not_found=raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1954, in xmlid_to_object t = self.xmlid_to_res_model_res_id(xmlid, raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1938, in xmlid_to_res_model_res_id return self.xmlid_lookup(xmlid)[1:3] File "<decorator-gen-35>", line 2, in xmlid_lookup File "/opt/odoo/odoo/tools/cache.py", line 90, in lookup value = d[key] = self.method(*args, **kwargs) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1931, in xmlid_lookup raise ValueError('External ID not found in the system: %s' % xmlid) ValueError: External ID not found in the system: product.product_product_4d 2022-10-21 07:38:54,676 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: Starting TestFatturaPAXMLValidation.test_intra_EU_draft ... 2022-10-21 07:38:56,177 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ====================================================================== 2022-10-21 07:38:56,178 253 ERROR odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ERROR: TestFatturaPAXMLValidation.test_intra_EU_draft Traceback (most recent call last): File "/opt/odoo/odoo/tools/cache.py", line 85, in lookup r = d[key] File "/opt/odoo/odoo/tools/func.py", line 71, in wrapper return func(self, *args, **kwargs) File "/opt/odoo/odoo/tools/lru.py", line 34, in __getitem__ a = self.d[obj] KeyError: ('ir.model.data', <function IrModelData.xmlid_lookup at 0x7f81573e0158>, 'product.product_product_4d') During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 151, in test_intra_EU_draft taxes=self.tax_22ai, File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 71, in _create_invoice line_form.product_id = cls.env.ref("product.product_product_4d") File "/opt/odoo/odoo/api.py", line 514, in ref return self['ir.model.data'].xmlid_to_object(xml_id, raise_if_not_found=raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1954, in xmlid_to_object t = self.xmlid_to_res_model_res_id(xmlid, raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1938, in xmlid_to_res_model_res_id return self.xmlid_lookup(xmlid)[1:3] File "<decorator-gen-35>", line 2, in xmlid_lookup File "/opt/odoo/odoo/tools/cache.py", line 90, in lookup value = d[key] = self.method(*args, **kwargs) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1931, in xmlid_lookup raise ValueError('External ID not found in the system: %s' % xmlid) ValueError: External ID not found in the system: product.product_product_4d 2022-10-21 07:38:56,179 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: Starting TestFatturaPAXMLValidation.test_intra_EU_supplier_refund ... 2022-10-21 07:38:57,722 253 INFO odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ====================================================================== 2022-10-21 07:38:57,723 253 ERROR odoo odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ERROR: TestFatturaPAXMLValidation.test_intra_EU_supplier_refund Traceback (most recent call last): File "/opt/odoo/odoo/tools/cache.py", line 85, in lookup r = d[key] File "/opt/odoo/odoo/tools/func.py", line 71, in wrapper return func(self, *args, **kwargs) File "/opt/odoo/odoo/tools/lru.py", line 34, in __getitem__ a = self.d[obj] KeyError: ('ir.model.data', <function IrModelData.xmlid_lookup at 0x7f81573e0158>, 'product.product_product_4d') During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 175, in test_intra_EU_supplier_refund taxes=self.tax_22ai, File "/__w/l10n-italy/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 71, in _create_invoice line_form.product_id = cls.env.ref("product.product_product_4d") File "/opt/odoo/odoo/api.py", line 514, in ref return self['ir.model.data'].xmlid_to_object(xml_id, raise_if_not_found=raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1954, in xmlid_to_object t = self.xmlid_to_res_model_res_id(xmlid, raise_if_not_found) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1938, in xmlid_to_res_model_res_id return self.xmlid_lookup(xmlid)[1:3] File "<decorator-gen-35>", line 2, in xmlid_lookup File "/opt/odoo/odoo/tools/cache.py", line 90, in lookup value = d[key] = self.method(*args, **kwargs) File "/opt/odoo/odoo/addons/base/models/ir_model.py", line 1931, in xmlid_lookup raise ValueError('External ID not found in the system: %s' % xmlid) ValueError: External ID not found in the system: product.product_product_4d
Currently translated at 100.0% (19 of 19 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fatturapa_out_rc Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_out_rc/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d4bc0a6
to
d802c53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie della PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puoi schiacciare i commit dei bot come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests?
<Data>2020-12-01</Data> | ||
<Numero>SLF/2020/12/0001</Numero> | ||
<Data>2020-12-31</Data> | ||
<Numero>SLF/2020/00001</Numero> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come mai devono essere cambiate le date delle fatture elettroniche nei test?
) | ||
invoice_form.partner_id = partner | ||
invoice_form.name = name | ||
invoice_form.invoice_date = fields.Date.from_string(invoice_date) | ||
invoice_form.date = fields.Date.from_string(invoice_date) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come mai qui non viene più impostata la data?
Potrebbe essere questo il motivo per cui le fatture elettroniche hanno date diverse.
self.supplier_extraEU.property_payment_term_id = self.term_15_30.id | ||
self.rc_type_eeu.with_supplier_self_invoice = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Credo che questa modifica e le successive in questo test facciano cambiare proprio il significato del test, coprendo un caso diverso da quello che copriva in 14.0
.
Come mai sono necessarie per la migrazione?
t-value="invoices.mapped('rc_purchase_invoice_id.rc_original_purchase_invoice_ids.partner_id') | ||
if invoices.rc_purchase_invoice_id.rc_original_purchase_invoice_ids | ||
else invoices.mapped('rc_purchase_invoice_id.partner_id')" | ||
t-value="invoices.mapped('rc_purchase_invoice_id.partner_id')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qui viene tagliato via il caso if invoices.rc_purchase_invoice_id.rc_original_purchase_invoice_ids
, come mai?
Prendo in carico la migrazione per risolvere i punti aperti in #3202 (review) |
Sostituita da #3515 |
No description provided.