Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] pos_order_count_store #883

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

robinkeunen
Copy link

  • stores pos_order_count field to use it in filters and pivot view
  • adds pos_order_ids field to use it in pivot view

Already discussed in beescoop/Obeesdoo#468

robinkeunen added a commit to beescoop/Obeesdoo that referenced this pull request Nov 14, 2022
@victor-champonnois
Copy link
Member

@legalsylvain for a follow up from beescoop/Obeesdoo#468

Copy link
Member

@victor-champonnois victor-champonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-883-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 36b4a25 into OCA:12.0 Nov 15, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 37a86bb. Thanks a lot for contributing to OCA. ❤️

victor-champonnois pushed a commit to beescoop/Obeesdoo that referenced this pull request Nov 15, 2022
Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/beescoop/Obeesdoo/issues>`_.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the links in this section need to be changed to oca?

@@ -0,0 +1,58 @@
=====================
Beesdoo POS Reporting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beesdoo can be omitted?

Maintainers
~~~~~~~~~~~

This module is part of the `beescoop/Obeesdoo <https://github.com/beescoop/Obeesdoo/tree/12.0/beesdoo_pos_reporting>`_ project on GitHub.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link update?

:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-beescoop%2FObeesdoo-lightgray.png?logo=github
:target: https://github.com/beescoop/Obeesdoo/tree/12.0/beesdoo_pos_reporting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link?

</div>
<div class="section" id="maintainers">
<h2><a class="toc-backref" href="#id5">Maintainers</a></h2>
<p>This module is part of the <a class="reference external" href="https://github.com/beescoop/obeesdoo/tree/12.0/beesdoo_pos_reporting">beescoop/obeesdoo</a> project on GitHub.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and several more in this document)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ferdymercury Thanks for the review. All the "beesdoo leftover" you raised will be erased by the OCABOT when it generates new readme.rst and index.html on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants