12.0 rename beesdoo pos reporting

[victor-champonnois]

Description

fix #346

related PR

• [ADD] pos_order_count_store OCA/pos#883

Odoo task (if applicable)

Checklist before approval

• Tests are present (or not needed).
• Credits/copyright have been changed correctly.
• Change log snippet is present.
• (If a new module) Moving this to OCA has been considered.

[codecov-commenter]

Codecov Report

Merging #468 (9f47909) into 12.0 (acee7a1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             12.0     #468      +/-   ##
==========================================
+ Coverage   61.83%   61.93%   +0.09%     
==========================================
  Files         167      168       +1     
  Lines        5348     5356       +8     
  Branches      937      937              
==========================================
+ Hits         3307     3317      +10     
+ Misses       1902     1901       -1     
+ Partials      139      138       -1     

Impacted Files	Coverage Δ
pos_order_count_store/models/__init__.py	100.00% <ø> (ø)
pos_order_count_store/models/res_partner.py	100.00% <100.00%> (ø)
pos_order_count_store/pre_init_hook.py	100.00% <100.00%> (ø)
beesdoo_shift/models/res_partner.py	43.58% <0.00%> (+1.70%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[robinkeunen]

Looks good but could it be moved to the oca directly?

[victor-champonnois]

@robinkeunen according to https://user-images.githubusercontent.com/17589077/149927982-58f1b329-9d15-48d3-b331-77741f7c2e87.png it should be moved to cie-pos, plans have changed ?

[robinkeunen]

My point of view has changed now yes. Maybe @legalsylvain could tell us whether he thinks pos_order_count_store would be welcome on oca/pos ?

The description.rst :

Store pos_order_count to improve reporting.

[legalsylvain]

Hi.

Thanks for the ping. I think that the module pos_order_count_store has its place under OCA umbrella. (generic and add features), as far as the "update" question is OK.

I think that if yes, you should add a pre-init-hook script to compute by SQL the stored field.
Otherwise, installing this module on existing databases (the GRAP one, for instance) will take hours for sure.

[legalsylvain]

I fear that if we make an update all, the update of point_of_sale module drop the column, and then, the update of the pos_order_count_store module recompute it. Am I wrong ?

[legalsylvain]

(I remember that I developed one time a module store = True -> store =False, and that was problematic.

[victor-champonnois]

Thank you for your reply

I fear that if we make an update all, the update of point_of_sale module drop the column, and then, the update of the pos_order_count_store module recompute it. Am I wrong ?

It's not what I observe, when updating point_of_sale (and then pos_order_count_store), the field was never recomputed.

Noted for the SQL Query in pre-init hook, I'll do that !

[victor-champonnois]

• I added the pre_init_hook
• @polchampion OK to test on coopeco-test and lesptitpots-test. To be tested : "Store pos_order_count to improve reporting." (check that the number of pos_order per partner is OK)

[robinkeunen]

Thx for the pre-init hook 👍 Can you rebase, squash and move the module to oca/pos ?

[robinkeunen]

/ocabot rebase

[github-grap-bot]

Congratulations, PR rebased to 12.0.

[victor-champonnois]

/ocabot rebase

[victor-champonnois]

@robinkeunen LGTM, should be merged for next MEP, so that pos_counter_store is installed

[victor-champonnois]

@robinkeunen can you approve the PR ?

[polchampion]

@victor-champonnois Sucessfully tested on coopeco-test : number of pos orders for one partner seems right (smart button on profile + pos order dynamic table view + filter on all orders for that partner.