[15.0][IMP] website_form_require_legal: Set link to terms and conditions #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Dec 13, 2023
| @@ -35,7 +35,6 @@ odoo.define("website_form_require_legal.form_editor", function (require) { | |||
| $(template).html( | |||
| qweb.render("website_form_require_legal.s_website_form_legal", { | |||
| labelWidth: labelWidth, | |||
| termsURL: "terms", | |||
There was a problem hiding this comment.
Why removing this default value?
There was a problem hiding this comment.
I confirm that this is working with a sane default /terms, so please restore it with that value.
Improve the template by allowing to set the URL when rendering the qweb template by setting a value for the termsURL variable by context. TT40305
pilarvargas-tecnativa
force-pushed
the
15.0-imp-website_form_require_legal
branch
from
a6558be to
a914de6
Compare
pedrobaeza
approved these changes
Dec 13, 2023
CarlosRoca13
approved these changes
Dec 14, 2023
chienandalu
approved these changes
Dec 14, 2023
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0d42647. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the template by allowing to set the URL when rendering the qweb template by setting a value for the termsURL variable by context.
cc @Tecnativa TT40305
@pedrobaeza @chienandalu please review