Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] website_form_require_legal: Set link to terms and conditions #1025

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[15.0][IMP] website_form_require_legal: Set link to terms and conditions #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website_form_require_legal/static/src/js/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ odoo.define("website_form_require_legal.form_editor", function (require) {
$(template).html(
qweb.render("website_form_require_legal.s_website_form_legal", {
labelWidth: labelWidth,
termsURL: "terms",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this default value?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this is working with a sane default /terms, so please restore it with that value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

termsURL: "/terms",
})
);
const legal = template.content.firstElementChild;
Expand Down
4 changes: 3 additions & 1 deletion website_form_require_legal/static/src/xml/website_form_editor.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
class="s_website_form_input form-check-input"
/>
<span class="form-check-label">
Agree to <a href="#">terms and conditions</a>
Agree to <a
t-attf-href="#{termsURL or '#'}"
>terms and conditions</a>
</span>
<div class="invalid-feedback">
You must agree before submitting.
Expand Down
Loading