v3.4.0

OHDSI · Oct 31, 2023 · 64796ac · 64796ac
1 parent 4d89788
commit 64796ac
Show file tree

Hide file tree

Showing 12 changed files with 84 additions and 86 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: Cyclops
 Type: Package
 Title: Cyclic Coordinate Descent for Logistic, Poisson and Survival Analysis
-Version: 3.3.1.999
+Version: 3.4.0
 Authors@R: c(
     person("Marc A.", "Suchard", email = "msuchard@ucla.edu", role = c("aut","cre")),
     person("Martijn J.", "Schuemie", role = "aut"),
@@ -50,4 +50,7 @@ Suggests:
     ggplot2,
     microbenchmark,
     cmprsk
+NeedsCompilation: yes
 RoxygenNote: 7.2.3
+Roxygen: list(markdown = TRUE)
+Encoding: UTF-8
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,16 +1,9 @@
-## Resubmission after VALGRIND feedback from Brian Ripley
+## Submission of v3.4.0
 
-* fixed VALGRIND uninitialized value (UB) issue; variable 'priorType' was uninitialized,
-  specifically in:
-
-    ==2293460== Conditional jump or move depends on uninitialised value(s)
-    ==2293460==    at 0x22CE4848: bsccs::CyclicCoordinateDescent::computeAsymptoticPrecisionMatrix() (packages/tests-vg/Cyclops/src/cyclops/CyclicCoordinateDescent.cpp:1335)
+* fixed use of deprecated `$` function in `dbplyr` using CRAN errors
 
-* fixed VALGRIND memory leak issue; was caused by calls to '::Rf_error()' instead of 
-  'Rcpp::stop()' when handling some error edge-cases
-
 ## Test environments
-* local OS X install, R 4.1
+* local OS X install, R 4.3
 * r-devel-valgrind docker container
 * ubuntu 20.04 (via gh-actions: devel and release)
 * win-builder (devel and release)

diff --git a/man/Multitype.Rd b/man/Multitype.Rd
diff --git a/man/aconfint.Rd b/man/aconfint.Rd
diff --git a/man/convertToCyclopsData.Rd b/man/convertToCyclopsData.Rd
diff --git a/man/convertToTimeVaryingCoef.Rd b/man/convertToTimeVaryingCoef.Rd
diff --git a/man/createControl.Rd b/man/createControl.Rd
diff --git a/man/createCyclopsData.Rd b/man/createCyclopsData.Rd
diff --git a/man/fitCyclopsModel.Rd b/man/fitCyclopsModel.Rd
diff --git a/man/oxford.Rd b/man/oxford.Rd
diff --git a/man/readCyclopsData.Rd b/man/readCyclopsData.Rd
diff --git a/man/splitTime.Rd b/man/splitTime.Rd