Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#257
@schuemie, Here's a simple approach that seems to work but relies on
:::
I think CRAN might allow it but require some justification. Seems fine in this case to me.
I tried another approach as well where I temporarily modified the class of the connection. The ::: seems best to me as long as CRAN allows it.
I also removed the dynamic class creation in the class cache since the only classes we need to define are unique to DatabaseConnector.
I removed oracleTempSchema and the code for deprecated database systems.
I've made progress on adding logical type support. On Oracle the package is still converting NA's to FALSE which needs to be fixed. Also I noticed uploading NA's of logical or integer type on Oracle is really slow.