Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dbplyr native backends #286

Merged
merged 13 commits into from
Aug 28, 2024
Merged

Use dbplyr native backends #286

merged 13 commits into from
Aug 28, 2024

Conversation

ablack3
Copy link
Collaborator

@ablack3 ablack3 commented Aug 17, 2024

#257

@schuemie, Here's a simple approach that seems to work but relies on :::
I think CRAN might allow it but require some justification. Seems fine in this case to me.

I tried another approach as well where I temporarily modified the class of the connection. The ::: seems best to me as long as CRAN allows it.

I also removed the dynamic class creation in the class cache since the only classes we need to define are unique to DatabaseConnector.

I removed oracleTempSchema and the code for deprecated database systems.

I've made progress on adding logical type support. On Oracle the package is still converting NA's to FALSE which needs to be fixed. Also I noticed uploading NA's of logical or integer type on Oracle is really slow.

@schuemie
Copy link
Member

ChatGPT says you can avoid ::: by using get(), e.g.:

oracle_sql_translation <- get("sql_translation.Oracle", envir = asNamespace("dbplyr"))

(Not sure CRAN will like that either ;-) )

Talk to you tomorrow!

@schuemie schuemie changed the base branch from develop to version_7 August 28, 2024 10:08
@ablack3 ablack3 marked this pull request as ready for review August 28, 2024 10:08
@schuemie schuemie merged commit 0fa9968 into OHDSI:version_7 Aug 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants