OXDEV-7325: Correct test names and add type hints; Remove unnecessary…

… usages;
OXID-eSales · Dec 6, 2023 · 96382d6 · 96382d6
1 parent d6caf99
commit 96382d6
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/tests/Unit/Infrastructure/ThemeSettingRepositorySettersTest.php b/tests/Unit/Infrastructure/ThemeSettingRepositorySettersTest.php
@@ -27,14 +27,16 @@ public function testSetterThrowsExceptionOnNotExistingSetting(
         $name = 'notExistingSetting';
         $themeId = 'awesomeTheme';
 
-        $repository = $this->getSut(methods: [$checkMethod]);
-        $repository->method($checkMethod)
+        $sut = $this->getSut(methods: [$checkMethod, 'saveSettingValue']);
+        $sut->method($checkMethod)
             ->with($name, $themeId)
             ->willThrowException(new NoSettingsFoundForThemeException($themeId));
+        $sut->expects($this->never())
+            ->method('saveSettingValue');
 
         $this->expectException(NoSettingsFoundForThemeException::class);
 
-        $repository->$repositoryMethod($name, $value, $themeId);
+        $sut->$repositoryMethod($name, $value, $themeId);
     }
 
     public function notExistingSettingCheckTriggerDataProvider(): \Generator
@@ -47,7 +49,7 @@ public function notExistingSettingCheckTriggerDataProvider(): \Generator
         yield "saveFloatSetting" => [
             'checkMethod' => 'getFloat',
             'repositoryMethod' => 'saveFloatSetting',
-            'value' => 1_23
+            'value' => 1.23
         ];
         yield "saveBooleanSetting" => [
             'checkMethod' => 'getBoolean',