Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve missing internal files as 404 instead of soft-404 page #2983

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Serve missing internal files as 404 instead of soft-404 page #2983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions web/src/routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ router.get(`/$/rss/:claimName::claimId`, rssMiddleware);
router.get(`/$/oembed`, oEmbedMiddleware);

router.get('*', async (ctx) => {
const requestedUrl = ctx.url;

if (requestedUrl.startsWith('/public/') && requestedUrl.endsWith('.js')) {
// If the file exists, `app.use(serve(DIST_ROOT))` would have handled it.
// Handle the non-existent file here, otherwise it'll get resolved to a
// claim with the name 'public'.
ctx.status = 404;
ctx.body = 'Resource not found';
ctx.set('Cache-Control', 'no-store');
return;
}

const html = await getHtml(ctx);
ctx.body = html;
});
Expand Down
Loading