-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Peak CAN driver #14
base: ag/tracing
Are you sure you want to change the base?
Conversation
a5c5e7d
to
cf7edb6
Compare
I completed the implementation of PCAN that supports all interfaces. Anyway I dont have any PCAN to test it. |
I suspect this lint was added to clippy since we last merged to main, and that the CI/CD pipeline uses the latest clippy release.
a850b7c
to
eec1282
Compare
Fedora PCAN-Basic installation instructionssudo dnf install kernel-devel popt-devel
tar -xzvf peak-linux-driver-8.16.0.tar.gz
cd peak-linux-driver-8.16.0/
make KERNEL_LOCATION=/usr/src/kernels/6.5.9-200.fc38.x86_64/ clean
EXTRA_CFLAGS=-Wno-error=incompatible-pointer-types make KERNEL_LOCATION=/usr/src/kernels/6.5.9-200.fc38.x86_64/ NET=NETDEV_SUPPORT all
sudo make KERNEL_LOCATION=/usr/src/kernels/6.5.9-200.fc38.x86_64/ install Question: Should this be a netdev or chardev network device? The peak driver documentation says they now default to using chardev.
|
builds, driver works, no functional test (no pcan available) --------- Co-authored-by: Jannes Brands <jannes@jannesbrands.de> Co-authored-by: Austin Gill <notgnoshi@gmail.com>
Including pcan support in the tests requires the test environment have libpcanbasic available, which has to be built from source.
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
dc2d922
to
cdbdb18
Compare
I don't have a way of testing this, so I have no idea how far off it is.