-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Peak CAN driver #14
Open
Notgnoshi
wants to merge
7
commits into
ag/tracing
Choose a base branch
from
ag/pcan
base: ag/tracing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f0dbdd - Browse repository at this point
Copy the full SHA 9f0dbddView commit details -
clippy: Fix unwrap-or-default lint
I suspect this lint was added to clippy since we last merged to main, and that the CI/CD pipeline uses the latest clippy release.
Configuration menu - View commit details
-
Copy full SHA for dc2d922 - Browse repository at this point
Copy the full SHA dc2d922View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ea2476 - Browse repository at this point
Copy the full SHA 6ea2476View commit details -
builds, driver works, no functional test (no pcan available) --------- Co-authored-by: Jannes Brands <jannes@jannesbrands.de> Co-authored-by: Austin Gill <notgnoshi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c2200b1 - Browse repository at this point
Copy the full SHA c2200b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 753c5aa - Browse repository at this point
Copy the full SHA 753c5aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 548b87a - Browse repository at this point
Copy the full SHA 548b87aView commit details -
Including pcan support in the tests requires the test environment have libpcanbasic available, which has to be built from source.
Configuration menu - View commit details
-
Copy full SHA for 623c3eb - Browse repository at this point
Copy the full SHA 623c3ebView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.