fix: add more robust version of ndvi

[LukeWeidenwalker]

closes #126

[codecov]

Codecov Report

Merging #147 (9bae349) into main (d60a286) will increase coverage by 2.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   75.81%   78.80%   +2.99%     
==========================================
  Files          26       27       +1     
  Lines        1170     1175       +5     
==========================================
+ Hits          887      926      +39     
+ Misses        283      249      -34     

Files Changed	Coverage Δ
...neo_processes_dask/process_implementations/math.py	59.86% <ø> (+10.96%)	⬆️
...ses_dask/process_implementations/cubes/__init__.py	100.00% <100.00%> (ø)
...sses_dask/process_implementations/cubes/indices.py	100.00% <100.00%> (ø)
...ocesses_dask/process_implementations/exceptions.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[LukeWeidenwalker]

@clausmichele could use a review from you on this if you have time! :)

[LukeWeidenwalker]

Or @ValentinaHutter now that she's back! :)

[ValentinaHutter]

I think this only works if band_dim is actually called "bands".

See https://processes.openeo.org/#ndvi under
Return Value:
target_band is a string: The data cube keeps the same dimensions. The dimension properties remain unchanged, but the number of dimension labels for the dimension of type bands increases by one. The additional label is named as specified in target_band.

[LukeWeidenwalker]

Ah, good catch, have updated this to work slightly differently! :)

[ValentinaHutter]

LGTM! just some minor comments - maybe also add a test to check if the target_band label is set correctly in the band_dim.