Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add more robust version of ndvi #147
fix: add more robust version of ndvi #147
Changes from 3 commits
fe780ad
7a9dd02
8ee96f2
ba3ecdb
bc83245
a483ccb
9bae349
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 15 in openeo_processes_dask/process_implementations/cubes/indices.py
Codecov / codecov/patch
openeo_processes_dask/process_implementations/cubes/indices.py#L15
Check warning on line 25 in openeo_processes_dask/process_implementations/cubes/indices.py
Codecov / codecov/patch
openeo_processes_dask/process_implementations/cubes/indices.py#L24-L25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this only works if band_dim is actually called "bands".
See https://processes.openeo.org/#ndvi under
Return Value:
target_band is a string: The data cube keeps the same dimensions. The dimension properties remain unchanged, but the number of dimension labels for the dimension of type bands increases by one. The additional label is named as specified in target_band.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch, have updated this to work slightly differently! :)