fix: persist the salveof conf item when slaveof no one is executed

[cheniujh]

当执行slaveof no one时，自动将配置持久化，以确保pika.conf中的slaveof字段也得到清空

Summary by CodeRabbit

• New Features

  • Introduced a method for handling the configuration rewrite process specifically for the slaveof setting.
  • Enhanced configuration management capabilities related to the slaveof configuration.

• Bug Fixes

  • Updated configuration to reflect the removal of the slave relationship when the relevant command is executed.

[coderabbitai]

Walkthrough

The changes involve the addition of a new method, ConfigRewriteSlaveOf(), in the PikaConf class to manage the configuration rewrite process for the slaveof setting. This method is integrated into the existing configuration management framework, enhancing its capabilities. Additionally, the SlaveofCmd::Do method in src/pika_admin.cc is modified to call this new method when the server is no longer a slave. The overall structure of the classes remains stable, with no new public interfaces introduced.

Changes

File	Change Summary
include/pika_conf.h	Added method: int ConfigRewriteSlaveOf() in class PikaConf.
src/pika_admin.cc	Modified SlaveofCmd::Do to call g_pika_conf->ConfigRewriteSlaveOf(); when is_none_ is true.
src/pika_conf.cc	Added method: int ConfigRewriteSlaveOf() in class PikaConf. Modified ConfigRewriteReplicationID to include a comment.

Poem

In the garden where configs play,
A new method hops in, bright and gay.
"Slaveof" whispers, "I'm no more,"
As changes bloom, we explore!
With locks in place, all's safe and sound,
In Pika's realm, new joys abound! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7fcb916 and 3bd9b94.

📒 Files selected for processing (3)

• include/pika_conf.h (1 hunks)
• src/pika_admin.cc (1 hunks)
• src/pika_conf.cc (1 hunks)

🔇 Additional comments (3)

include/pika_conf.h (1)

941-941: LGTM!

The declaration follows the existing pattern of config rewrite methods in the class.

src/pika_conf.cc (1)

935-957: LGTM!

The implementation follows the established pattern of config rewrite methods, with proper thread safety and error handling.

src/pika_admin.cc (1)

155-155: LGTM!

The call to ConfigRewriteSlaveOf() is correctly placed to persist the slaveof configuration when clearing slave status.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.