Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve type annotation errors and local variable naming conflicts. #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

401lrx
Copy link

@401lrx 401lrx commented Mar 23, 2024

  • Fix bug / bug

💡 Background or solution

  • The role_assign method of the TasksolvingRule class is invoked by the step method of the BasicEnvironment class in tasksolving. The agents passed during the call are of dictionary type and they are used as dictionaries within the role_assign method. Therefore, there exists a type annotation error.
  • In the role_assign method of Rule class, the list of critic agents obtained by calling the astep method of role_assigner is saved in a variable named agents, which causes a naming conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant