Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter way to catch missing columns error #469 #470

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Alter way to catch missing columns error #469 #470

merged 8 commits into from
Nov 20, 2023

Conversation

FlorianK13
Copy link
Member

@FlorianK13 FlorianK13 commented Oct 6, 2023 •
edited
Loading

Instead of getting the column name from the
error message, the missing columns are now received by comparing the existing database table with the new dataframe.

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@FlorianK13
Alter way to catch missing columns error #469
0be8d9f 
Instead of getting the column name from the
error message, the missing columns are now received by comparing
the existing database table with the new dataframe.
@FlorianK13 FlorianK13 mentioned this pull request Oct 6, 2023
Closed
1 task
@FlorianK13 FlorianK13 requested a review from chrwm October 6, 2023 12:33
@FlorianK13 FlorianK13 marked this pull request as ready for review October 6, 2023 12:33
@FlorianK13
Delete while True loop #469
ea3bbb5 
Better have a for loop with a large number which will still stop
at some point.
@FlorianK13
Move add_missing_columns outside of loop #469
5163caa 
Additionally rename function and change
while True loop to for loop
@FlorianK13
Merge branch 'bugfix-469-add_missing_column_to_table' of github.com:O…
2561c85 
…penEnergyPlatform/open-MaStR into bugfix-469-add_missing_column_to_table
@FlorianK13
Copy link
Member Author

Tests are failing due to #466 I assume.

@FlorianK13 FlorianK13 mentioned this pull request Oct 10, 2023
Closed
5 tasks
@FlorianK13
Copy link
Member Author

Do you think we can merge @chrwm ?

@FlorianK13 FlorianK13 linked an issue Nov 2, 2023 that may be closed by this pull request
add_missing_column_to_table fails as the quotation marks mismatch #469
Closed
1 task
chrwm
chrwm approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrwm chrwm merged commit 4fc6d35 into develop Nov 20, 2023
6 checks passed
@chrwm chrwm deleted the bugfix-469-add_missing_column_to_table branch November 20, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-schmid k-schmid k-schmid left review comments

@chrwm chrwm chrwm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add_missing_column_to_table fails as the quotation marks mismatch
3 participants
@FlorianK13 @k-schmid @chrwm