Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and test all images, add apptainer #170

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mikemhenry
Copy link
Collaborator

@mikemhenry mikemhenry commented Aug 23, 2023

Added tests for the docker images
Added apptainer building (we probably only need to build the compute and not the server image)

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b831756) 82.45% compared to head (93cea25) 82.45%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files          21       21           
  Lines        2679     2679           
=======================================
  Hits         2209     2209           
  Misses        470      470           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotsdl dotsdl self-requested a review August 24, 2023 00:45
@mikemhenry
Copy link
Collaborator Author

I was shocked when this was all green, but I forgot to set it up to actually run the docker building 😮‍💨

@mikemhenry mikemhenry marked this pull request as draft August 24, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants