Consider dash symbols in combined symbols #2154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dl3sdo
force-pushed
the
dash-points-combined-symbols
branch
from
676d238
to
044165a
Compare
Closed
dl3sdo
force-pushed
the
dash-points-combined-symbols
branch
from
044165a
to
165bf3d
Compare
dg0yt
reviewed
Aug 23, 2024
src/tools/tool_helpers.cpp
Outdated
| * Function is used by DrawPathTool::updateDashPointDrawing() and | ||
| * EditPointTool::addDashPointDefault() in relation to setting and changing dash points. | ||
| */ | ||
| bool symbolContainsDashSymbol(const Symbol* symbol) |
There was a problem hiding this comment.
I think this should become a virtual member function Symbol::containsDashSymbol, with suitable overrides in subclasses.
For line symbols and combined symbols determine if the symbol contains a dash symbol.
When drawing line objects for symbols with dash symbols, no dash points were set automatically if the symbol was a combined symbol. When editing line objects for symbols with dash symbols, additional points were not added as dash points if the symbol was a combined symbol. These deviations were known and marked as TODO. This change treats line symbols with dash symbols and combined symbols containing line symbols with dash symbols equally.
dl3sdo
force-pushed
the
dash-points-combined-symbols
branch
from
165bf3d
to
acaa4a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When drawing line objects for symbols with dash symbols, no dash points were set automatically if the symbol was a combined symbol.
When editing line objects for symbols with dash symbols, additional points were not added as dash points if the symbol was a combined symbol.
These deviations were known and marked as TODO.
This commit treats line symbols with dash symbols and combined symbols containing line symbols with dash symbols equally.