-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: stdcm simulation convoy parameters #9106
Conversation
3e1d5c0
to
f82a6f6
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9106 +/- ##
============================================
+ Coverage 39.15% 39.39% +0.24%
- Complexity 2245 2267 +22
============================================
Files 1290 1302 +12
Lines 97316 98353 +1037
Branches 3280 3301 +21
============================================
+ Hits 38100 38743 +643
- Misses 57277 57658 +381
- Partials 1939 1952 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
928bd3c
to
2e56d31
Compare
97512ff
to
1920dba
Compare
1920dba
to
55fb369
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few comments:
9dd25e0
to
f6e616b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR
2f3113f
to
577f67e
Compare
8f647a2
to
ce6d40b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests and other fields.
d2b4329
to
69d506e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR ! I left some comments (mostly typos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left some comments
Also depending on who finishes first, you might have conflicts with this PR : #9268 |
2dc09eb
to
eb9e14d
Compare
2d6a9d2
to
92f6141
Compare
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
92f6141
to
3f5bd10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job ! We can keep the negative input feature for another issue, as it needs another refacto of the style of this part of the form.
Issue here : #9374
I fixed all comments and we need to merge
part of #8670 and https://github.com/osrd-project/osrd-confidential/issues/368
How to test: