-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: remove set current simulation inputs state stdcm #9268
front: remove set current simulation inputs state stdcm #9268
Conversation
ff1d48f
to
0c147b0
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9268 +/- ##
=========================================
Coverage 39.25% 39.26%
Complexity 2267 2267
=========================================
Files 1305 1306 +1
Lines 98762 98734 -28
Branches 3310 3311 +1
=========================================
- Hits 38771 38764 -7
+ Misses 58030 58008 -22
- Partials 1961 1962 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR will probably conflict with this one : #9106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i only left tiny comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, LGTM
63542ed
to
ec7a5cc
Compare
ec7a5cc
to
f4dde5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from this question, looks good! Thanks a bunch for cleaning this up :)
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
57e16a4
to
3d6e1fe
Compare
closes #9267