Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove set current simulation inputs state stdcm #9268

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 9, 2024

closes #9267

@clarani clarani force-pushed the cni/9267-remove-setCurrentSimulationInputs-state-stdcm branch from ff1d48f to 0c147b0 Compare October 10, 2024 15:18
@clarani clarani marked this pull request as ready for review October 10, 2024 15:18
@clarani clarani requested a review from a team as a code owner October 10, 2024 15:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 39.26%. Comparing base (fdecde7) to head (3d6e1fe).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ont/src/applications/stdcmV2/hooks/useStdcmForm.ts 0.00% 25 Missing and 1 partial ⚠️
...rc/applications/stdcmV2/components/StdcmConfig.tsx 0.00% 4 Missing ⚠️
...c/applications/stdcmV2/components/StdcmConsist.tsx 0.00% 4 Missing ⚠️
...plications/stdcmV2/components/StdcmDestination.tsx 0.00% 1 Missing and 1 partial ⚠️
...rc/applications/stdcmV2/components/StdcmOrigin.tsx 0.00% 1 Missing and 1 partial ⚠️
...ont/src/applications/stdcmV2/views/StdcmViewV2.tsx 0.00% 2 Missing ⚠️
.../src/applications/stdcmV2/components/StdcmVias.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #9268   +/-   ##
=========================================
  Coverage     39.25%   39.26%           
  Complexity     2267     2267           
=========================================
  Files          1305     1306    +1     
  Lines         98762    98734   -28     
  Branches       3310     3311    +1     
=========================================
- Hits          38771    38764    -7     
+ Misses        58030    58008   -22     
- Partials       1961     1962    +1     
Flag Coverage Δ
core 74.97% <ø> (ø)
editoast 71.99% <ø> (-0.03%) ⬇️
front 10.36% <0.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani requested review from Akctarus and SharglutDev and removed request for Math-R and Uriel-Sautron October 14, 2024 13:56
@SharglutDev
Copy link
Contributor

This PR will probably conflict with this one : #9106

Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i only left tiny comments :)

front/src/applications/stdcmV2/components/StdcmConfig.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmConfig.tsx Outdated Show resolved Hide resolved
front/src/applications/stdcmV2/components/StdcmConfig.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@clarani clarani force-pushed the cni/9267-remove-setCurrentSimulationInputs-state-stdcm branch from 63542ed to ec7a5cc Compare October 16, 2024 07:19
@clarani clarani force-pushed the cni/9267-remove-setCurrentSimulationInputs-state-stdcm branch from ec7a5cc to f4dde5d Compare October 18, 2024 11:32
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this question, looks good! Thanks a bunch for cleaning this up :)

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/9267-remove-setCurrentSimulationInputs-state-stdcm branch from 57e16a4 to 3d6e1fe Compare October 21, 2024 07:37
@clarani clarani added this pull request to the merge queue Oct 21, 2024
Merged via the queue into dev with commit 02e76f0 Oct 21, 2024
24 checks passed
@clarani clarani deleted the cni/9267-remove-setCurrentSimulationInputs-state-stdcm branch October 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: remove the state setCurrentSimulationInputs in stdcm
6 participants