-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pool fees when rebalancing Aerodrome AMO #2276
Open
sparrowDom
wants to merge
17
commits into
master
Choose a base branch
from
sparrowDom/aerodromeAMOswapFees
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5eff2e7
make aerodrome AMO leave swap fees when rebalancing
sparrowDom e61c8d2
minor adjustements and test fixes
sparrowDom d503200
fix bug
sparrowDom a9f4d28
burn OETHb on the contract and minor renames
sparrowDom 946061a
fix various issues with quoter and the tests
sparrowDom 8f4547f
space
sparrowDom 2e40c70
undo removal of default values
sparrowDom 5cf3b53
remove comment
sparrowDom df55f83
add view to _checkForExpectedPoolPrice function
sparrowDom c1ee4ef
burn all the Super OETHb after performing the swap
sparrowDom 05a567f
put back burning OETHb after the swap function
sparrowDom 9d9b15a
add comment
sparrowDom c49c541
minor test correction
sparrowDom 80a25db
OETHb on the contract after rebalance should be 0
sparrowDom 3bd3be1
simplify nr of functions
sparrowDom 7fdd6c3
Aerodrome AMO remove liquidity proper fix (#2290)
sparrowDom cf8084c
ignore dust in burning oeth as well
sparrowDom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
const { deployOnBaseWithGuardian } = require("../../utils/deploy-l2"); | ||
const { | ||
deployBaseAerodromeAMOStrategyImplementation, | ||
} = require("../deployActions"); | ||
|
||
module.exports = deployOnBaseWithGuardian( | ||
{ | ||
deployName: "018_upgrade_amo", | ||
}, | ||
async ({ ethers }) => { | ||
const cAMOStrategyProxy = await ethers.getContract( | ||
"AerodromeAMOStrategyProxy" | ||
); | ||
const cAMOStrategyImpl = | ||
await deployBaseAerodromeAMOStrategyImplementation(); | ||
|
||
return { | ||
actions: [ | ||
{ | ||
// 1. Upgrade AMO | ||
contract: cAMOStrategyProxy, | ||
signature: "upgradeTo(address)", | ||
args: [cAMOStrategyImpl.address], | ||
}, | ||
], | ||
}; | ||
} | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to do this > 1e12 thing inside
_burnOethbOnTheContract()
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed it makes sense as a defensive measure: cf8084c