-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some attachments can have a larger radius than others #841
Draft
NermNermNerm
wants to merge
4
commits into
Pathoschild:develop
Choose a base branch
from
NermNermNerm:extendDistance
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9be6710
Enable attachments that are commonly used and non-destructive to have…
SteveBenz f83f5e8
Reverted unneeded changes, cleaned some usings, and updated comments
SteveBenz 86c74c9
Merge remote-tracking branch 'origin/alpha' into extendDistance
SteveBenz 5cae0a0
Merge remote-tracking branch 'origin/develop' into extendDistance
SteveBenz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
namespace Pathoschild.Stardew.TractorMod.Framework.Config | ||
{ | ||
/// <summary>Configuration for an attachment which just has on/off and might be long-range.</summary> | ||
internal class ExtendedDistanceConfig : IExtendedDistanceConfig | ||
{ | ||
/// <summary>Whether to enable the attachment.</summary> | ||
public bool Enable { get; set; } = true; | ||
|
||
/// <summary>If true, causes the area of effect to be increased somewhat from <see cref="ModConfig.Distance"/></summary> | ||
public bool IncreaseDistance { get; set; } = true; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
namespace Pathoschild.Stardew.TractorMod.Framework.Config | ||
{ | ||
/// <summary> | ||
/// Attachments that can affect a wider radius implement this config | ||
/// </summary> | ||
internal interface IExtendedDistanceConfig | ||
{ | ||
/// <summary>If true, causes the area of effect to be increased somewhat from <see cref="ModConfig.Distance"/></summary> | ||
public bool IncreaseDistance { get; set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
using Pathoschild.Stardew.TractorMod.Framework.Config; | ||
using StardewModdingAPI; | ||
|
||
namespace Pathoschild.Stardew.TractorMod.Framework | ||
{ | ||
/// <summary>The base class for attachments that can operate over a larger area. | ||
/// </summary> | ||
/// <typeparam name="TConfig">The type of the config file.</typeparam> | ||
internal abstract class ExtendedDistanceAttachment<TConfig> : BaseAttachment | ||
NermNermNerm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
where TConfig : IExtendedDistanceConfig | ||
|
||
{ | ||
/// <summary>Construct an instance.</summary> | ||
/// <param name="config">The configuration for the attachment.</param> | ||
protected ExtendedDistanceAttachment(TConfig config, IModRegistry modRegistry, int rateLimit = 0) | ||
: base(modRegistry, rateLimit) | ||
{ | ||
this.Config = config; | ||
} | ||
|
||
/// <summary>The configuration for the attachment.</summary> | ||
protected TConfig Config { get; } | ||
|
||
/// <summary>If true, the attachment's area of affect should be expanded by a tile.</summary> | ||
public override bool IsDistanceExtended => this.Config.IncreaseDistance; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For fertilizer and seeding, I felt like it fits the "non-destructive" idea, but as for playing this way all the time, I'm not so sure. It's a rarely done activity, so personally, I care more about precision than speed. So I made it something that folks could turn on if they felt differently about it, but left if off by default.