Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #94 and #106 #104

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Fixing #94 and #106 #104

merged 7 commits into from
Jun 11, 2024

Conversation

oganm
Copy link
Member

@oganm oganm commented May 16, 2024

No description provided.

@arteymix
Copy link
Member

That's a bit of an odd watcher. Can you check if the clear all selection button at the bottom of the settings still work?

@oganm
Copy link
Member Author

oganm commented May 16, 2024

Nope very much broken..

Another new if not functionally too important issue is that if i

  • select a mouse and a human microarray
  • select human

the mouse microarray will still be selected despite not being part of the tree anymore

@oganm
Copy link
Member Author

oganm commented May 16, 2024

This latest commit fixes the clear all issue using a ref. I am unsure if keeping non-existent parts of the tree selected is a real issue since people may want to preserve their selections regardless

@oganm oganm marked this pull request as ready for review May 16, 2024 06:18
@oganm oganm changed the title Fixing #94 Fixing #94 and #106 Jun 11, 2024
@oganm
Copy link
Member Author

oganm commented Jun 11, 2024

@arteymix this removes the components/PlatformSelector.js. it seemed to be an earlier version of TechnologyTypeSelector. and creates a platformConstants.js to import some constants. should be ready to be merged otherwise

@arteymix arteymix merged commit 54d4372 into master Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants