Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only copy over the direct superclass of our terms from other ontologies #20

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

arteymix
Copy link
Member

@arteymix arteymix commented Nov 26, 2023

This makes it much easier to work with the ontology file and in principle shouldn't affect our ability to perform ontology inference.

I have to check first if the inference with Gemma still works properly as we would be lacking the full set of super/sub-class hierarchy and part of/has part relations.

@arteymix arteymix force-pushed the wip/remove-imports branch 2 times, most recently from adb6548 to 806b2c0 Compare November 26, 2023 18:25
@arteymix arteymix self-assigned this Nov 26, 2023
@arteymix arteymix requested a review from ppavlidis November 26, 2023 18:27
Copy link
Contributor

@ppavlidis ppavlidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand what you are saying but you might need to explain why this is a concern? Performance(

We don't use GENO separately except via TGEMO and only need a few terms from it, and are unlikely to use many other ones.

@arteymix
Copy link
Member Author

Yes, this is about performance for both Gemma but also QoL for curators that have to wait 5 minutes for Protégé to load right now.

@arteymix
Copy link
Member Author

I've addressed the issue of inference across ontologies in PavlidisLab/Gemma@4300e77, and I already went ahead with disabling import for TGEMO in tests to speed them up. This will be in the 1.31, so I'll wait until it's out before merging.

arteymix added a commit to PavlidisLab/Gemma that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants