Add interface to lightning.qubit MCM preprocessing
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudit2812
commented
Jun 12, 2024
|
[sc-65738] |
multiphaseCFD
approved these changes
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #760 +/- ##
==========================================
- Coverage 97.06% 93.00% -4.06%
==========================================
Files 109 17 -92
Lines 15694 1902 -13792
==========================================
- Hits 15233 1769 -13464
+ Misses 461 133 -328 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently blocked by PennyLaneAI/pennylane#5791. Device preprocessing is being moved inside the ML boundary, so the interface information needed for correct
hw-likepostselection is being lost when usingdynamic_one_shot.Description of the Change:
qml.devices.preprocess.mid_circuit_measurementsaccepts an additionalinterfacekwarg, which is now being used inLightningQubit.preprocess.Benefits:
Expected behaviour with
mcm_method="one-shot",postselect_mode="hw-like", andjax.jit.Possible Drawbacks:
Related GitHub Issues: