Move device preprocessing to inner execute #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astralcai
changed the title
astralcai
changed the title
Closed
1 task
mudit2812
reviewed
Jun 7, 2024
…o inner-execute
mudit2812
reviewed
Jun 10, 2024
…o inner-execute
trbromley
reviewed
Jun 11, 2024
dwierichs
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Looks good to me, thanks @astralcai !
Just had a small suggestion for one test, and wanted to follow up on open comments.
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
…o inner-execute
albi3ro
reviewed
Jun 12, 2024
albi3ro
reviewed
Jun 12, 2024
albi3ro
reviewed
Jun 12, 2024
tests/interfaces/default_qubit_2_integration/test_jax_jit_qnode_default_qubit_2.py
Show resolved
Hide resolved
Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
reviewed
Jun 12, 2024
mudit2812
added a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Jun 13, 2024
**Context:** Currently blocked by PennyLaneAI/pennylane#5791. Device preprocessing is being moved inside the ML boundary, so the interface information needed for correct `hw-like` postselection is being lost when using `dynamic_one_shot`. **Description of the Change:** `qml.devices.preprocess.mid_circuit_measurements` accepts an additional `interface` kwarg, which is now being used in `LightningQubit.preprocess`. **Benefits:** Expected behaviour with `mcm_method="one-shot"`, `postselect_mode="hw-like"`, and `jax.jit`. **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
1 task
mudit2812
added a commit
that referenced
this pull request
Jul 26, 2024
**Context:** As name says. Gradient workflows no longer raise errors after the merge of #5791 , but their correctness is yet to be verified. **Description of the Change:** * Updated casting rules in `dynamic_one_shot`'s processing function for tensorflow. * For the changes to be fully integrated, the way that the interface is passed around when calling a QNode needed to be changed, so the following changes were made: * `QNode` has updated behaviour for how `mcm_config` is used during execution. In `QNode._execution_component`, a copy of `self.execute_kwargs["mcm_config"]` is the source of truth, and in `qml.execute`, `config.mcm_config` is the source of truth. * Added a private `pad-invalid-samples` `postselect_mode`. The `postselect_mode` is switched to this automatically in `qml.execute` if executing with jax and shots and `postselect_mode == "hw-like"`. This way we standardize how the MCM transforms determine if jax is being used. * Updates to `capture` module to accommodate the above changes. **Benefits:** * `dynamic_one_shot` doesn't cast to interfaces inside the ML boundary * `dynamic_one_shot` works with tensorflow * Expanded tests **Possible Drawbacks:** **Related GitHub Issues:** Fixes #5736, #5710 Duplicate of #5861 which was closed due to release branch merge stuff. --------- Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca> Co-authored-by: Astral Cai <astral.cai@xanadu.ai> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com> Co-authored-by: Christina Lee <chrissie.c.l@gmail.com> Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com> Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai> Co-authored-by: Ahmed Darwish <exclass9.24@gmail.com> Co-authored-by: Utkarsh <utkarshazad98@gmail.com> Co-authored-by: David Wierichs <david.wierichs@xanadu.ai> Co-authored-by: Christina Lee <christina@xanadu.ai> Co-authored-by: Mikhail Andrenkov <mikhail@xanadu.ai> Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com> Co-authored-by: Josh Izaac <josh146@gmail.com> Co-authored-by: Diego <diego_guala@hotmail.com> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com> Co-authored-by: Jack Brown <jack@xanadu.ai> Co-authored-by: Paul Finlay <50180049+doctorperceptron@users.noreply.github.com> Co-authored-by: David Ittah <dime10@users.noreply.github.com> Co-authored-by: Cristian Emiliano Godinez Ramirez <57567043+EmilianoG-byte@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
If there is a gradient transform, we want device preprocessing to happen within the ml boundary, i.e., in
inner_execute, to avoid applying the gradient transform on transformed tapes produced by device preprocessing.Description of the Change:
inner_transformkeyword toqml.executeQNode._execute_componentandqml.executeto add device preprocessing to the inner transform program if thegradient_fnis a gradient transform.Related GitHub Issues:
[sc-59107]