Qutrit channel amplitude damping #5503
Conversation
…nylane_qutrit_mixer into qutrit_channel_depolarizing
…to checked operator and observable lists
There was a problem hiding this comment.
@albi3ro, @glassnotes, @mudit2812, and @trbromley I have finished this PR and added some comments. I look forward to your reviews!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5503 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 415 416 +1
Lines 38898 38761 -137
==========================================
- Hits 38774 38636 -138
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@Gabriel-Bottrill looks great! Small comment re. gradient, and realized this and previous PR are missing integration tests for the channels.
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com> Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
There was a problem hiding this comment.
This looks good to me - thanks @Gabriel-Bottrill ! I will keep an eye on the remaining discussions, but I leave it to Mudit or Tom to give the final approval here.
|
The jax failures should fix themselves once you update the branch @Gabriel-Bottrill |
|
Thank you @mudit2812! |
**Context:** The QutritAmplitudeDamping channel #5503 and #5757 variable names are named with numbers, when making the TritFlip channel #5784 I realized that it would be better to specify subspaces for clarity. This PR is meant to change the name of QutritAmplitudeDamping's variables. **Description of the Change:** Change the name of the QutritAmplitudeDamping channel's variables from gamma_1, gamma_2, and gamma_3 to gamma_01, gamma_02, and gamma_12, respectively. **Benefits:** Makes the code more clear for which variables affect which subspace, reducing the need to check the docs. **Possible Drawbacks:** Changes the name of variables of development code. **Related GitHub Issues:** N/A --------- Co-authored-by: Gabriel Bottrill <bottrill@student.ubc.ca> Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Context:
default.qutrit.mixeddevice has been added, but only one channel has been added, qml.QutritDepolarizingChannel, this adds the second channel to the device so the device can simulate the qutrit equivalent of amplitude damping noise.Description of the Change:
Adds new channel module to
qml.ops.qutritpackage. Adding the second qutrit channelQutritAmplitudeDamping.Benefits:
Allows for
defualt.qutrit.mixedto simulate amplitude damping noise. Makingdefault.qutrit.mixed, much more useful.Possible Drawbacks:
N/A
Related GitHub Issues:
N/A