Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_trotter_is_used_if_num_steps_is_defined #5867

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Conversation

astralcai
Copy link
Contributor

@astralcai astralcai commented Jun 17, 2024

  1. Add assert to qml.equal such that the test case actually tests something.
  2. Fix the expected params for the decomposed gates.

[sc-66336]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (37bc2e6) to head (b5e8331).
Report is 244 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5867    +/-   ##
========================================
  Coverage   99.66%   99.67%            
========================================
  Files         421      421            
  Lines       40466    40170   -296     
========================================
- Hits        40332    40040   -292     
+ Misses        134      130     -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/ops/op_math/test_exp.py Show resolved Hide resolved
tests/ops/op_math/test_exp.py Outdated Show resolved Hide resolved
tests/ops/op_math/test_exp.py Show resolved Hide resolved
@astralcai astralcai added this to the v0.37 milestone Jun 18, 2024
tests/ops/op_math/test_exp.py Outdated Show resolved Hide resolved
@astralcai astralcai enabled auto-merge (squash) June 18, 2024 18:14
@astralcai astralcai merged commit 209867b into master Jun 18, 2024
40 checks passed
@astralcai astralcai deleted the trotter-test branch June 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants