Add deprecation warning to from_qasm #5882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5882 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 422 422
Lines 40658 40367 -291
==========================================
- Hits 40525 40233 -292
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
lillian542
reviewed
Jun 20, 2024
lillian542
approved these changes
Jun 20, 2024
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
albi3ro
reviewed
Jun 20, 2024
albi3ro
reviewed
Jun 20, 2024
Co-authored-by: Christina Lee <christina@xanadu.ai>
dwierichs
approved these changes
Jun 20, 2024
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
|
don't forget to add an entry in deprecations.rst! |
ooops, will do. |
trbromley
reviewed
Jun 21, 2024
Comment on lines
+507
to
+515
| if measurements is False: | ||
| warnings.warn( | ||
| "The current default behaviour of removing measurements in the QASM code is " | ||
| "deprecated. Set measurements=None to keep the existing measurements in the QASM " | ||
| "code or set measurements=[] to remove them from the returned circuit. Starting " | ||
| "in version 0.38, measurements=None will be the new default.", | ||
| qml.PennyLaneDeprecationWarning, | ||
| ) | ||
| measurements = [] |
There was a problem hiding this comment.
Here I was expecting to only raise a warning if measurements is False and there are measurements present in the QASM circuit. Is that something we could determine?
There was a problem hiding this comment.
I'll make another PR to do that.
mudit2812
pushed a commit
that referenced
this pull request
Jul 2, 2024
**Context:** Previously, the QASM circuit converted to PL had no measurements (even if the circuit ended with measurements, the assumption was we remove those and add PL measurements once the circuit is converted). In the UnitaryHack, a contributor added the option to specify measurements when converting a circuit `from_qasm`, like the `from_qiskit` function. In doing so, the `from_qasm` circuit took on the current `from_qiskit` convention. Calling `from_qasm(qasm_str)` previously returned only the operators, and now returns operators + measurements. This is a breaking change with no deprecation cycle. PennyLaneAI/pennylane-qiskit#469 **Description of the Change:** Adds a deprecation warning to `from_qasm` [sc-66318] --------- Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com> Co-authored-by: Christina Lee <christina@xanadu.ai> Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Previously, the QASM circuit converted to PL had no measurements (even if the circuit ended with measurements, the assumption was we remove those and add PL measurements once the circuit is converted).
In the UnitaryHack, a contributor added the option to specify measurements when converting a circuit
from_qasm, like thefrom_qiskitfunction. In doing so, thefrom_qasmcircuit took on the currentfrom_qiskitconvention. Callingfrom_qasm(qasm_str)previously returned only the operators, and now returns operators + measurements. This is a breaking change with no deprecation cycle.PennyLaneAI/pennylane-qiskit#469
Description of the Change:
Adds a deprecation warning to
from_qasm[sc-66318]