Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation QubitStateVector #6172

Merged
merged 17 commits into from
Sep 17, 2024
Merged

Deprecation QubitStateVector #6172

merged 17 commits into from
Sep 17, 2024

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Aug 28, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (b78565c) to head (e3f1b19).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6172   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         443      444    +1     
  Lines       42273    42336   +63     
=======================================
+ Hits        42096    42159   +63     
  Misses        177      177

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetpuntoG KetpuntoG changed the title [WIP] deprecation QubitStateVector Deprecation QubitStateVector Aug 29, 2024
@KetpuntoG KetpuntoG requested a review from soranjh August 29, 2024 19:22
soranjh
soranjh reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KetpuntoG. Some of the changes seem bit irrelevant, left questions on them.

tests/ops/functions/test_assert_valid.py Outdated Show resolved Hide resolved
tests/ops/functions/test_assert_valid.py Outdated Show resolved Hide resolved
tests/ops/qubit/test_attributes.py Outdated Show resolved Hide resolved
soranjh
soranjh approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KetpuntoG, looks good to go.

@soranjh soranjh mentioned this pull request Sep 12, 2024
Merged
AmintorDusko
AmintorDusko approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@KetpuntoG KetpuntoG merged commit fa97f16 into master Sep 17, 2024
36 checks passed
@KetpuntoG KetpuntoG deleted the deprecate_QubitStateVector branch September 17, 2024 14:52
mudit2812 pushed a commit that referenced this pull request Sep 18, 2024
@KetpuntoG @mudit2812
Deprecation QubitStateVector (#6172)
f5d1807 
[sc-72046]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soranjh soranjh soranjh approved these changes

@AmintorDusko AmintorDusko AmintorDusko approved these changes

@albi3ro albi3ro Awaiting requested review from albi3ro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KetpuntoG @albi3ro @soranjh @AmintorDusko