Deprecate top level access to legacy device base classes #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliasadi
added a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Sep 11, 2024
**Context:** In [PennyLane PR #6238](PennyLaneAI/pennylane#6238) we will be deprecating top level access to `QubitDevice`. **Description of the Change:** Imports `QubitDevice` from `pennylane.devices` instead. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-71519] --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
…aneAI/pennylane into deprecate-toplevel-device
…aneAI/pennylane into deprecate-toplevel-device
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6238 +/- ##
==========================================
- Coverage 99.59% 99.58% -0.02%
==========================================
Files 444 443 -1
Lines 42321 42231 -90
==========================================
- Hits 42149 42054 -95
- Misses 172 177 +5 ☔ View full report in Codecov by Sentry. |
albi3ro
commented
Sep 13, 2024
astralcai
reviewed
Sep 13, 2024
astralcai
approved these changes
Sep 13, 2024
mudit2812
approved these changes
Sep 13, 2024
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
added a commit
that referenced
this pull request
Sep 16, 2024
**Context:** `qml.Device`, `qml.QubitDevice`, and `qml.QutritDevice` all reflect the legacy device interface, which is no longer the recommended way of creating devices. **Description of the Change:** Deprecate top level access to the `Device`, `QubitDevice`, and `QutritDevice`. **Benefits:** Further isolation of the legacy device interface. **Possible Drawbacks:** All deprecations propagate through the ecosystem and can cause issues. **Related GitHub Issues:** [sc-71519] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
added a commit
that referenced
this pull request
Sep 16, 2024
**Context:** `qml.Device`, `qml.QubitDevice`, and `qml.QutritDevice` all reflect the legacy device interface, which is no longer the recommended way of creating devices. **Description of the Change:** Deprecate top level access to the `Device`, `QubitDevice`, and `QutritDevice`. **Benefits:** Further isolation of the legacy device interface. **Possible Drawbacks:** All deprecations propagate through the ecosystem and can cause issues. **Related GitHub Issues:** [sc-71519] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812
added a commit
that referenced
this pull request
Sep 18, 2024
**Context:** `qml.Device`, `qml.QubitDevice`, and `qml.QutritDevice` all reflect the legacy device interface, which is no longer the recommended way of creating devices. **Description of the Change:** Deprecate top level access to the `Device`, `QubitDevice`, and `QutritDevice`. **Benefits:** Further isolation of the legacy device interface. **Possible Drawbacks:** All deprecations propagate through the ecosystem and can cause issues. **Related GitHub Issues:** [sc-71519] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
qml.Device,qml.QubitDevice, andqml.QutritDeviceall reflect the legacy device interface, which is no longer the recommended way of creating devices.Description of the Change:
Deprecate top level access to the
Device,QubitDevice, andQutritDevice.Benefits:
Further isolation of the legacy device interface.
Possible Drawbacks:
All deprecations propagate through the ecosystem and can cause issues.
Related GitHub Issues:
[sc-71519]