devices.qubit.measure uses csr_dot_products only when it is usable.
#6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6278 +/- ##
==========================================
- Coverage 99.69% 99.69% -0.01%
==========================================
Files 443 444 +1
Lines 42022 42133 +111
==========================================
+ Hits 41894 42004 +110
- Misses 128 129 +1 ☔ View full report in Codecov by Sentry. |
mudit2812
reviewed
Sep 18, 2024
mudit2812
requested changes
Sep 18, 2024
mudit2812
reviewed
Sep 19, 2024
mudit2812
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
This looks good! I just have a couple of questions. Is this PR relevant for this bug?
Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
mudit2812
pushed a commit
that referenced
this pull request
Sep 23, 2024
…e. (#6278) There are a couple of scenarios when `csr_dot_products` is not usable for `Sum` and `Hamiltonians`: 1. When not all of the ops has a sparse matrix 2. When it's a legacy Hamiltonian and one of the ops are multi-wired. Fixes #6264 [sc-73590] [sc-73868] --------- Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
astralcai
added a commit
that referenced
this pull request
Sep 30, 2024
A follow up PR to #6278, fixes recent failure in legacy opmath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of scenarios when
csr_dot_productsis not usable forSumandHamiltonians:Fixes #6264
[sc-73590]
[sc-73868]