Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test on rolling CI #187

Merged
merged 7 commits into from
Aug 4, 2024
Merged

Fix test on rolling CI #187

merged 7 commits into from
Aug 4, 2024

Conversation

pac48
Copy link
Collaborator

@pac48 pac48 commented Mar 22, 2024

It appears that the CI for rolling might be running Python with optimization. This disables type checks causing a test to fail. This PR disables the test if the environment is set to optimize.

pac48 added 2 commits March 22, 2024 12:50
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
@pac48 pac48 marked this pull request as draft March 23, 2024 00:29
@pac48 pac48 closed this Aug 1, 2024
@pac48 pac48 reopened this Aug 1, 2024
pac48 added 4 commits August 2, 2024 08:52
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
@pac48 pac48 marked this pull request as ready for review August 2, 2024 16:14
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be fine, but I don't have that much experience with python + CI

@pac48 pac48 merged commit c798ce9 into main Aug 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants