Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudevents-server): add dead letter topic support #168

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Sep 9, 2024

No description provided.

Copy link

ti-chi-bot bot commented Sep 9, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Key Changes:

  • A new dead-letter topic support is added to the Kafka consumer configuration.
  • A new faultWriter is added to the NewEventConsumer function.
  • The handle function is changed to write the fault message to the faultWriter when the result is not ACK.
  • The consumer.Start function is changed to use the faultWriter.
  • The NewEventConsumerGroup function is changed to pass the faultWriter to the NewEventConsumer function.

Potential Problems:

  • There is no description provided for the pull request, which makes it difficult for reviewers to understand the purpose of this change.
  • The new dead-letter topic support could cause issues if not implemented correctly, such as a misconfiguration of the topic or a lack of monitoring for the dead-letter queue.
  • The code changes do not include any new tests, which means that the functionality may not be fully tested.

Fixing Suggestions:

  • Add a description to the pull request to provide context and explain the purpose of the changes.
  • Ensure that the new dead-letter topic support is implemented correctly, and add monitoring to detect any issues with the dead-letter queue.
  • Add new tests to cover the new functionality.
  • Consider adding more comments to the code to improve the readability and maintainability of the codebase.

@ti-chi-bot ti-chi-bot bot added the size/L label Sep 9, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 9, 2024

/approve

Copy link

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit eadd400 into main Sep 9, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/cloudevent-server-dead-letter-topic branch September 9, 2024 05:48
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-ops that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant