feat: add personal data link in footer #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillemonchicourt
approved these changes
Sep 26, 2024
juggler31
force-pushed
the
rgpd_link_personal_data
branch
2 times, most recently
from
5c7ced0 to
da2ab75
Compare
marcantoinedupre
suggested changes
Sep 27, 2024
There was a problem hiding this comment.
C'est globalement bon pour moi 👍
Je t'ai fait quelques remarques mineures. Pour les deux remarques qui concernent du code supprimé je pense qu'il peut être pertinent de le faire dans deux commits séparés avec une brêve explication dans les messages de commit. À toi de voir. :)
Le script ne fonctionnait plus depuis le commit : PnX-SI@c897d55
Les fichiers `.po`, `.mo`, et `.pot` n'était pas à jours, ce commit les met juste à jours.
juggler31
force-pushed
the
rgpd_link_personal_data
branch
2 times, most recently
from
30c094c to
864296a
Compare
juggler31
force-pushed
the
rgpd_link_personal_data
branch
from
864296a to
8c57c84
Compare
juggler31
commented
Sep 27, 2024
juggler31
force-pushed
the
rgpd_link_personal_data
branch
from
8c57c84 to
61d733e
Compare
|
il manquerait pas un changelog pour expliquer ? ou une doc |
juggler31
force-pushed
the
rgpd_link_personal_data
branch
from
61d733e to
7f0eae0
Compare
amandine-sahl
pushed a commit
that referenced
this pull request
Oct 15, 2024
* fix: remove script in footer.html template Le script ne fonctionnait plus depuis le commit : c897d55 * fix: remove babel extensions because they are integrated in package now * fix: launch translation cmd Les fichiers `.po`, `.mo`, et `.pot` n'était pas à jours, ce commit les met juste à jours. * feat: add personal data link in footer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#527
Cette PR a pour but de rajouter un lien dans le footer, faisant apparaître une modale .
Le texte contenu dans cette modale est surchargeable via un fichier
personal-data.htmlIl a pour but de renseigner les utilisateurs sur les données personnelles comme indiqué sur le site de la CNIL : https://www.cnil.fr/fr/exemples-de-formulaire-de-collecte-de-donnees-caractere-personnel
La modale par défaut: